Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add warp route ID lookup and validation to warp check command #5395

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

ljankovic-txfusion
Copy link
Collaborator

@ljankovic-txfusion ljankovic-txfusion commented Feb 7, 2025

Description

This PR introduces --warpRouteId flag to hl warp check command that allows users to directly specify a warp route ID to check. When --warpRouteId is not specified, a user is prompted to search for a route ID from the registry.

Drive-by changes

  • Check whether warp core & warp deploy config chains match with the clear state diff
  • Requires to pass warp core along with warp deploy config
  • Removes DEFAULT_WARP_ROUTE_DEPLOYMENT_CONFIG_PATH associated with config

Related issues

None

Backward compatibility

Yes

Testing

Updated cli e2e tests

Copy link

changeset-bot bot commented Feb 7, 2025

🦋 Changeset detected

Latest commit: 2ac2be8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@hyperlane-xyz/cli Minor
@hyperlane-xyz/infra Minor
@hyperlane-xyz/ccip-server Minor
@hyperlane-xyz/github-proxy Minor
@hyperlane-xyz/helloworld Minor
@hyperlane-xyz/sdk Minor
@hyperlane-xyz/utils Minor
@hyperlane-xyz/widgets Minor
@hyperlane-xyz/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (1f50bbc) to head (2ac2be8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5395   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

@jmrossy jmrossy removed their request for review February 10, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

1 participant