-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support CCIP Hooks and ISMs in the SDK #5413
base: feature/ccip-hook-and-ism
Are you sure you want to change the base?
Conversation
|
a82c1b4
to
ec73648
Compare
// NOTE: this deploys the ism too on the destination chain if it doesn't exist | ||
protected async deployCCIPHook({ | ||
config, | ||
}: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the CCIP hook/ism deploy logic has been moved to the HyperlaneCCIPDeployer in the next PR #5412
@@ -64,7 +64,7 @@ contract CCIPIsm is AbstractMessageIdAuthorizedIsm, CCIPReceiver { | |||
preVerifyMessage(messageId, msg.value); | |||
} | |||
|
|||
function _isAuthorized() internal pure override returns (bool) { | |||
function _isAuthorized() internal view override returns (bool) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
required to get build working
protected async deployCCIPIsm( | ||
destination: ChainName, | ||
config: CCIPIsmConfig, | ||
): Promise<CCIPIsm> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the CCIP hook/ism deploy logic has been moved to the HyperlaneCCIPDeployer in the next PR #5412
Description
feat: support CCIP Hooks and ISMs in the SDK
HyperlaneIsmFactory
,HyperlaneHookDeployer
,EvmHookModule
)EvmIsmReader
,EvmHookReader
)Drive-by changes
Related issues
Backward compatibility
Testing