Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support CCIP Hooks and ISMs in the SDK #5413

Draft
wants to merge 5 commits into
base: feature/ccip-hook-and-ism
Choose a base branch
from

Conversation

paulbalaji
Copy link
Contributor

@paulbalaji paulbalaji commented Feb 9, 2025

Description

feat: support CCIP Hooks and ISMs in the SDK

  • update schema/types for hooks/isms
  • create ccip constants copied from chainlink docs
  • create ccip utils to read different properties from the ccip constants
  • update deployers (HyperlaneIsmFactory, HyperlaneHookDeployer, EvmHookModule)
  • update readers to support ccip hook/ism (EvmIsmReader, EvmHookReader)

Drive-by changes

Related issues

Backward compatibility

Testing

Copy link

changeset-bot bot commented Feb 9, 2025

⚠️ No Changeset found

Latest commit: ec73648

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Comment on lines +931 to +934
// NOTE: this deploys the ism too on the destination chain if it doesn't exist
protected async deployCCIPHook({
config,
}: {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the CCIP hook/ism deploy logic has been moved to the HyperlaneCCIPDeployer in the next PR #5412

@@ -64,7 +64,7 @@ contract CCIPIsm is AbstractMessageIdAuthorizedIsm, CCIPReceiver {
preVerifyMessage(messageId, msg.value);
}

function _isAuthorized() internal pure override returns (bool) {
function _isAuthorized() internal view override returns (bool) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

required to get build working

Comment on lines +241 to +244
protected async deployCCIPIsm(
destination: ChainName,
config: CCIPIsmConfig,
): Promise<CCIPIsm> {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the CCIP hook/ism deploy logic has been moved to the HyperlaneCCIPDeployer in the next PR #5412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

2 participants