Investigation: trying to detect overwritten connector names #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AlexBHarley is attempting to deploy a commit to the Abacus Works Team on Vercel. A member of the Team first needs to authorize it. |
jmrossy
reviewed
Jun 13, 2024
There was a problem hiding this comment.
This PR should be in the motivation section for EIP 6963 haha
It's good to know we have some options, albeit hacky ones. If we do take this approach, I'd prefer if this logic were organized by protocol like the other stuff under src/wallet/hooks
|
Yeah, just wanted to provide as reference. I think the bigger win will be RainbowKit V2 as that does have 6963 support, and many wallets are supporting now. But that will be a much bigger upgrade I believe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can sometimes detect if an extension is overriding MetaMask, but the implementation is hacky and prone to breaking when wallets update what they inject.