Skip to content
This repository has been archived by the owner on Jan 27, 2022. It is now read-only.

Santander AML Example (Web Client part) #180

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Santander AML Example (Web Client part) #180

wants to merge 6 commits into from

Conversation

gbarcomu
Copy link
Contributor

This Web application is part of the Santander AML (Anty Money Laundering) example.
It is made in Vue.js. There is an nginx to serve the application and also as a reverse proxy to communicate with the TCF via rpc.
It shows the workers availables (WorkerLookUp) and their details (WorkerRetrieve), allows to send work orders (WorkOrderSubmit) and shows the response of the AML use case (WorkOrderGetResult).

The other part of the example is already merged in PR #164

Signed-off-by: pegartillo95 [email protected]
Signed-off-by: gbarcomu [email protected]
Signed-off-by: kubasiemion [email protected]

gbarcomu and others added 6 commits November 6, 2019 15:22
@gbarcomu @pegartillo95 @kubasiemion
TCF Web Client
3f9b7a9 
This Web application is part of the Santander AML (Anty Money Laundering) example.
It is made in Vue.js. There is an nginx  to serve the application and also as a reverse proxy to communicate with the TCF via rpc.
It shows the workers availables (WorkerLookUp) and their details (WorkerRetrieve), allows to send work orders (WorkOrderSubmit) and shows the response of the AML use case (WorkOrderGetResult).

Signed-off-by: pegartillo95 <[email protected]>
Signed-off-by: gbarcomu <[email protected]>
Signed-off-by: kubasiemion <[email protected]>

Co-authored-by: pegartillo95 <[email protected]>
Co-authored-by: gbarcomu <[email protected]>
Co-authored-by: kubasiemion <[email protected]>
@gbarcomu @pegartillo95 @kubasiemion
Added README license, splitted long lines
7298815 
Signed-off-by: pegartillo95 <[email protected]>
Signed-off-by: gbarcomu <[email protected]>
Signed-off-by: kubasiemion <[email protected]>

Co-authored-by: pegartillo95 <[email protected]>
Co-authored-by: gbarcomu <[email protected]>
Co-authored-by: kubasiemion <[email protected]>
@gbarcomu @pegartillo95 @kubasiemion
Changed docker compose aml to be compatible after PR hyperledger-arch…
671fa95 
…ives#148

Signed-off-by: pegartillo95 <[email protected]>
Signed-off-by: gbarcomu <[email protected]>
Signed-off-by: kubasiemion <[email protected]>

Co-authored-by: pegartillo95 <[email protected]>
Co-authored-by: gbarcomu <[email protected]>
Co-authored-by: kubasiemion <[email protected]>
@gbarcomu @pegartillo95 @kubasiemion
Minor changes
126462e 
Signed-off-by: pegartillo95 <[email protected]>
Signed-off-by: gbarcomu <[email protected]>
Signed-off-by: kubasiemion <[email protected]>

Co-authored-by: pegartillo95 <[email protected]>
Co-authored-by: gbarcomu <[email protected]>
Co-authored-by: kubasiemion <[email protected]>
@gbarcomu @pegartillo95 @kubasiemion
Merge master into master
bcceddc 
Signed-off-by: pegartillo95 <[email protected]>
Signed-off-by: gbarcomu <[email protected]>
Signed-off-by: kubasiemion <[email protected]>

Co-authored-by: pegartillo95 <[email protected]>
Co-authored-by: gbarcomu <[email protected]>
Co-authored-by: kubasiemion <[email protected]>
@gbarcomu @pegartillo95 @kubasiemion
Deleted information about how to make avalon stateful
060e8bc 
Signed-off-by: pegartillo95 <[email protected]>
Signed-off-by: gbarcomu <[email protected]>
Signed-off-by: kubasiemion <[email protected]>

Co-authored-by: pegartillo95 <[email protected]>
Co-authored-by: gbarcomu <[email protected]>
Co-authored-by: kubasiemion <[email protected]>
rranjan3
rranjan3 suggested changes Nov 29, 2019
View reviewed changes
Copy link
Contributor

@rranjan3 rranjan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried running the web client. Found a few points worth improvement. We also need to double check if the Santander logo can be used herein, this being a Hyperledger project. https://github.com/hyperledger/avalon/blob/master/LICENSE#L138

examples/apps/aml/web-client/README.md
docker-compose up
```

10. Open a browser and check if everything is deployed correctly. There must be some workers in "Available Workers" slot.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of steps to guide through the UI would be much appreciated. And a sample request attached along.

examples/apps/aml/web-client/src/App.vue
</b-table>
</div>

<b-modal size="lg" title="Worker Details" ref="modal" @show="nullWorker" ok-only>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This component seems to break on chrome 78.0.39.
image

examples/apps/aml/web-client/README.md

8. Go to "deployment" folder.

9. Execute
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can npm build/run be moved to docker? Need to build outside and then deploy for any new changes.

examples/apps/aml/web-client/src/config.js

export default {

SERVER_URL : 'http://{YOUR DOMAIN}.com/',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refrain from using trailing separators '/'. Sanitize in implementation and use. As I tried to run, I casually removed it as an IP had to be supplied. I spent some build cycles to get over it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How should I modify it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SERVER_URL : '{YOUR SERVER URL}', // eg - http://localohost, http://myaml.com
This would suffice. While using, you could append the trailing separator '/'.

danintel
danintel suggested changes Dec 4, 2019
View reviewed changes
examples/apps/aml/workload/aml_logic.cpp
}

/* This function iterates all transaction lists looking for cycles
* and returns a string containing differents sets of suspects
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/differents/different/

examples/apps/aml/workload/aml_logic.cpp
std::string AmlResultLogic::getNameFromId(std::string id) {
std::string country = id.substr(0,2);
int i;
for(i = 0; i < numberTotalCountries; i++){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For here and everywhere else add a space after for and if.
That is change for( to for ( and if( to if (

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rranjan3 rranjan3 rranjan3 requested changes

@danintel danintel danintel requested changes

@dcmiddle dcmiddle Awaiting requested review from dcmiddle

@EugeneYYY EugeneYYY Awaiting requested review from EugeneYYY

@manju956 manju956 Awaiting requested review from manju956

@manojgop manojgop Awaiting requested review from manojgop

@pankajgoyal2 pankajgoyal2 Awaiting requested review from pankajgoyal2

@Ram-srini Ram-srini Awaiting requested review from Ram-srini

@TomBarnes TomBarnes Awaiting requested review from TomBarnes

@karthikamurthy karthikamurthy Awaiting requested review from karthikamurthy

@SriharshaSubbakrishna SriharshaSubbakrishna Awaiting requested review from SriharshaSubbakrishna

Assignees

@gbarcomu gbarcomu

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gbarcomu @danintel @rranjan3