Bug fix to address work order receipt flow in work order sync mode execution #440
Conversation
Ram-srini
requested review from
danintel,
dcmiddle,
EugeneYYY,
manju956,
manojgop,
pankajgoyal2 and
TomBarnes
as code owners
|
@Ram-srini Could you update the commit message with details of the bug in work order receipt flow in sync mode. |
| if receipt_entry is None: | ||
| receipt_entry = { | ||
| "params": { | ||
| "receiptUpdates": [] |
There was a problem hiding this comment.
Do we have any param like "receiptUpdates" in the spec ?
There was a problem hiding this comment.
No. This is implementation specific, need to store the receipt updates in that tag.
| @@ -82,12 +82,22 @@ def WorkOrderReceiptCreate(self, **params): | |||
| ) | |||
| else: | |||
| wo_receipt = self.kv_helper.get("wo-receipts", wo_id) | |||
| if wo_receipt is None: | |||
| wo_receipt = json.loads(wo_receipt) | |||
| if wo_receipt and "workOrderId" not in wo_receipt["params"]: | |||
There was a problem hiding this comment.
Under what scenario will workOrderId be not part of wo_receipt ? My understanding is receipt is for a specific work order. So a receipt does not exists without a work order
There was a problem hiding this comment.
WorkOrderId is exists if work order receipt is created. Refer the git issues for description #412
| updated_receipt)) | ||
| logger.info("Receipt for the workorder id %s is updated to %s", | ||
| wo_id, wo_receipt) | ||
| # If receipt is not created yet, add tag "receiptUpdates" to |
| self.private_key | ||
| ) | ||
|
|
||
| # If it is first update to receipt |
There was a problem hiding this comment.
it is first update >>> is not the first update
| "Receipt for the workorder id %s is completed " + | ||
| "and no further updates are allowed", | ||
| wo_id) | ||
| return |
There was a problem hiding this comment.
Can there be contradictory receipt updates coupled with COMPLETED ? Most probably no. Otherwise we might still want to check whats the latest one and not return.
There was a problem hiding this comment.
always check the latest status of receipt, if it is COMPLETED then there won't be further updates to it.
Address the git issue - hyperledger-archives#412 Signed-off-by: Ramakrishna Srinivasamurthy <[email protected]>
Since listener config is hard-coded with container service name and it is failing in standlone mode. Added command line option to listener to read zmq_url and defact value in config file is localhost and command line argument takes precedence. Signed-off-by: Ramakrishna Srinivasamurthy <[email protected]>
Ram-srini
requested review from
karthikamurthy and
SriharshaSubbakrishna
as code owners
To fix issue - #412
Signed-off-by: Ramakrishna Srinivasamurthy [email protected]