-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): add iroha transaction get
and other important commands
#5289
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Shunkichi Sato <[email protected]>
Signed-off-by: Shunkichi Sato <[email protected]>
| `peer` | Execute commands related to peer administration and networking | | ||
| `wasm` | Execute commands related to WASM | | ||
| `help` | Print the help message for `iroha` and/or the current subcommand other than `help` subcommand | | ||
See [Command-Line Help](CommandLineHelp.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delegate the usage description to an auto-generated Command-Line Help
{ | ||
"sumeragi": { | ||
"block_time_ms": 2001 | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
snake_case for consistency with FindParameters
query result to cut and reuse it as SetParameter
input
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Iroha JS supports this, but I am not sure I understand your point and what's the issue here. Could you help me understand?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is, for example,
{
"Sumeragi": {
"BlockTimeMs": 2001
}
}
will be failing to deserialize to SumeragiParameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some #[serde(...)]
attributes don't change the schema, so it seems easy for them to silently break the API
Signed-off-by: Shunkichi Sato <[email protected]>
Signed-off-by: Shunkichi Sato <[email protected]>
Signed-off-by: Shunkichi Sato <[email protected]>
Signed-off-by: Shunkichi Sato <[email protected]>
…mands Signed-off-by: Shunkichi Sato <[email protected]>
4f5d6d5
to
1c5adf3
Compare
Signed-off-by: Shunkichi Sato <[email protected]>
…mands Signed-off-by: Shunkichi Sato <[email protected]>
Signed-off-by: Shunkichi Sato <[email protected]>
…mands Signed-off-by: Shunkichi Sato <[email protected]>
0093bea
to
8bcdcac
Compare
…mands Signed-off-by: Shunkichi Sato <[email protected]>
Signed-off-by: Shunkichi Sato <[email protected]>
## [2.0.0-rc.1.1] - 2025-02-08 | ||
|
||
### Added | ||
|
||
- add `iroha transaction get` and other important commands (#5289) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this follows the backporting workflow @mversic
Also,
- Update
CHANGELOG
in a separate commit (we must have an entry for patch versions in themain
branch as well)
Why do we update the CHANGELOG.md
in the main branch for every minor version change due to backporting? Wouldn't it be sufficient to update it only in the release branches?
Context
Implements essential but previously missing commands in the client CLI. See Command Line Help
Register<Trigger>
ExecuteTrigger
Custom
remain unimplementedFindAccountsWithAsset
FindBlocks
FindBlockHeaders
remain unimplementedLog
instruction fails to serialize due to non-sensical#[serde(flatten)]
on thelevel
field #5305Migration Guide
Some commands are changed in usage or behavior:
iroha json query
->iroha query stdin
iroha json transaction
->iroha transaction stdin
iroha wasm
->iroha transaction wasm
iroha * metadata
->iroha * meta
iroha asset
get-key-value
->getkv
set-key-value
->setkv
remove-key-value
->removekv
iroha events
data
->state
transaction-pipeline
->transaction
block-pipeline
->block
execute-trigger
->trigger-execute
trigger-completed
->trigger-complete
iroha * list all
->iroha * list all --verbose
iroha * list all
lists only IDs and is intended to be used in combination withiroha * get --id
, which retrieves the details of a single entry.Checklist
CONTRIBUTING.md
.