Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #20: Connect API to the frontend of the application #29

Merged
merged 6 commits into from
Aug 6, 2024

Conversation

xtzhang1122
Copy link

@xtzhang1122 xtzhang1122 commented Jul 21, 2024

Description

This PR addresses Issue #20 . Users can now interact directly with the frontend, receiving their typed messages in the chatbox.

Due to hardware limitations, testing the connection between the frontend and backend hasn't been performed. The relevant code is written but currently commented out.

Current Progress

The image below demonstrates the current progress
Screenshot 2024-07-26 at 3 56 39 PM

Copy link
Contributor

@swaptr swaptr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting the PR, it looks very promising. However, this PR is failing the DCO check. Please sign your commits to resolve this issue.

@xtzhang1122 xtzhang1122 force-pushed the dev branch 2 times, most recently from 7ae98bc to 6c25d9e Compare July 23, 2024 13:32
@xtzhang1122 xtzhang1122 marked this pull request as ready for review July 23, 2024 13:33
@xtzhang1122 xtzhang1122 requested a review from swaptr July 24, 2024 05:15
@swaptr
Copy link
Contributor

swaptr commented Jul 24, 2024

For an initial version it looks good to me but the UI is broken:

Screenshot_20240724_105823

{chatSelected ? <WelcomeSection /> : <ChatSection />}
</div>
<ChatBottomBar />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The BottomBar enables two interactions here:

  1. Use the chat context to reply to messages.
  2. If no chat is selected then start a new chat.

So if you refactor it to the chat section then please note that you will need to add another ChatBottomBar to the welcome section that starts a new chat if that is the design you are going for.

Signed-off-by: xtzhang1122 <[email protected]>
Signed-off-by: xtzhang1122 <[email protected]>
Signed-off-by: xtzhang1122 <[email protected]>
Signed-off-by: xtzhang1122 <[email protected]>
Signed-off-by: xtzhang1122 <[email protected]>
@xtzhang1122 xtzhang1122 requested a review from swaptr August 5, 2024 09:06
@swaptr swaptr merged commit d150143 into hyperledger-labs:dev Aug 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants