Add isolation option to the vault lock #754
Conversation
alexandrosfilios
force-pushed
the
f-rwset-isolation
branch
4 times, most recently
from
73541a3 to
f3d4c82
Compare
|
@alexandrosfilios, can you add a performance test to measure how many transaction per second you can commit while producing RWSets? |
alexandrosfilios
force-pushed
the
f-rwset-isolation
branch
2 times, most recently
from
b096055 to
61be65e
Compare
Yes writing perf tests as part of another pr |
| @@ -82,15 +82,6 @@ func NewInterceptor[V driver.ValidationCode]( | |||
| } | |||
|
|
|||
| func (i *Interceptor[V]) IsValid() error { | |||
| tx, err := i.vaultStore.GetTxStatus(context.Background(), i.txID) | |||
There was a problem hiding this comment.
why is this check not needed anymore?
There was a problem hiding this comment.
because the db makes the check
There was a problem hiding this comment.
And this method is only needed in tests
| @@ -51,18 +51,13 @@ func newTxCodePersistence(readDB *sql.DB, writeDB common.WriteDB, tables common. | |||
|
|
|||
| func (db *VaultPersistence) Store(ctx context.Context, txIDs []driver.TxID, writes driver.Writes, metaWrites driver.MetaWrites) error { | |||
| span := trace.SpanFromContext(ctx) | |||
| span.AddEvent("start_store") | |||
| defer span.AddEvent("end_store") | |||
| span.AddEvent("Start store") | |||
There was a problem hiding this comment.
the rest of the code still uses the convention of separating words with _ and keeping everything lowercase. Was this intentional?
There was a problem hiding this comment.
Yes I am changing them all slowly because it is more readable on the UI side of Jaeger
alexandrosfilios
force-pushed
the
f-rwset-isolation
branch
from
61be65e to
f1a0818
Compare
Signed-off-by: Alexandros Filios <[email protected]>
Signed-off-by: Alexandros Filios <[email protected]>
alexandrosfilios
force-pushed
the
f-rwset-isolation
branch
from
f1a0818 to
de9cefa
Compare
No description provided.