ADD: nullity bitmap and hashes in storage #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Zamojski <[email protected]>
Signed-off-by: Thomas Zamojski <[email protected]>
|
matkt
requested changes
Jun 18, 2024
| int indicator = (int) encodedValues.get(0); | ||
| Bytes values = encodedValues.slice(1); | ||
| return switch (indicator) { | ||
| case 0 -> Optional.of(createRootNode(values)); |
There was a problem hiding this comment.
why not using an enum for that ?
enum NodeType {
ROOT(0),
INTERNAL(1),
STEM(2),
LEAF(3);
int type;
NodeType(final int type) {
this.type = type;
}
public int getType() {
return type;
}
}| throw new RuntimeException("cannot persist dirty node"); | ||
| } | ||
| nodeUpdater.store(location, null, leafNode.getEncodedValue()); | ||
| // if (leafNode.isPersisted()) { |
| List<Bytes> values = new ArrayList<>(nChild); | ||
| for (int i = 0; i < nChild; i++) { | ||
| if (!isNull.get(i)) { | ||
| Bytes value = encoded.slice(0, 32); |
There was a problem hiding this comment.
It is possible that a value is not 32 bytes. it is therefore possible to represent it with less byte and save space
example : UInt256.valueOf(1)
0x0000000000000000000000000000000000000000000000000000000000000001
|
@thomas-quadratic can we close this one ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Not included but possible next steps: