Adapt leaf key types to follow new eip-6800 spec #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luis Pinto <[email protected]>
|
matkt
approved these changes
Sep 4, 2024
Discussed with @matkt offline, since this is still in development there's no changelog yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
I observed while changing gas costs that a new spec for leaf keys has been released here: https://eips.ethereum.org/EIPS/
eip-6800 and the new gas costs schedule already uses that.
Mostly the changes are around encoding the balance, nonce, code size and version information into a single leaf called BASIC_DATA_LEAF which takes the position 0 in the suffix tree. The
CODEHASH_LEAFsupposedly replacingCODE_KECCAK_LEAF_KEYfrom old spec will take position 1. See below before and after along with references where it were taken from:old spec: https://ethereum-magicians.org/t/proposed-verkle-tree-scheme-for-ethereum-state/5805
new spec: https://eips.ethereum.org/EIPS/eip-6800