Refactor NullNode and remove NullLeafNode class #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luis Pinto <[email protected]> Remove NullLeafNode and use NullNode instead Signed-off-by: Luis Pinto <[email protected]>
|
matkt
approved these changes
Oct 2, 2024
| return isLeaf() ? "NullLeafNode" : "NullNode"; | ||
| } | ||
|
|
||
| @SuppressWarnings("rawtypes") |
There was a problem hiding this comment.
for NullNode class maybe better to have the @SuppressWarnings directly for the class ? and not for each method
There was a problem hiding this comment.
If we make it class wide then other accept methods might not report relevant warnings and they could be useful. I prefer to keep it locally to where we actually need to disable them
| return nullLeafNode; | ||
| } | ||
|
|
||
| public static <T> NullNode<T> nullLeafNode(Optional<T> previousValue) { |
There was a problem hiding this comment.
maybe better to rename the method to createNullLeafNode or newNullLeafNode
rename nullLeafNode to newNullLeafNode in NullNode Signed-off-by: Luis Pinto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove NullLeafNode and use NullNode instead