[VERKLE] Preload stems #7206
Open
[VERKLE] Preload stems #7206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karim Taam <[email protected]>
Signed-off-by: Karim Taam <[email protected]>
This was referenced Jun 19, 2024
garyschulte
reviewed
Jun 19, 2024
|
|
||
| private Map<Bytes32, Bytes32> getCachedTrieKeysForAccount(final Address address) { | ||
| return Optional.ofNullable(trieKeysCache.getIfPresent(address)) | ||
| .orElseGet(ConcurrentHashMap::new); |
There was a problem hiding this comment.
it doesn't look like trieKeysCache can ever be null in this case
garyschulte
reviewed
Jun 19, 2024
| CompletableFuture.runAsync(() -> cacheCodeTrieKeys(account, code)); | ||
| } | ||
|
|
||
| public Map<Bytes32, Bytes32> generateManyTrieKeyHashes( |
There was a problem hiding this comment.
do we really need to cache trieKeys? seems like the only expensive thing to cache would be the 31 byte stem address, and we can just suffix it at-will. It should reduce the cache size and might make for a better performing key generation on execution (since the stem would be cached and not regenerated if the slot key or code keys were not pre-calculated)
garyschulte
approved these changes
Jun 19, 2024
Signed-off-by: Karim Taam <[email protected]>
Signed-off-by: Karim Taam <[email protected]>
|
I updated the code in order to save stem , this one depends on this besu-verkle-trie PR hyperledger/besu-verkle-trie#64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Currently, trie keys generation will gather all transactions data and generate a single large batch of trie keys at once.
However, there are already mechanisms implemented in Besu to preload those trie keys in a background thread during block processing.
This PR generates the different triekeys in the background in order to have a maximum of triekeys already calculated at the end of the block
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests