Sync no tx index while sync #8181
Open
+119
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Frame <[email protected]>
Signed-off-by: Jason Frame <[email protected]>
Signed-off-by: Jason Frame <[email protected]>
Signed-off-by: Jason Frame <[email protected]>
Signed-off-by: Jason Frame <[email protected]>
Signed-off-by: Jason Frame <[email protected]>
Signed-off-by: Jason Frame <[email protected]>
Signed-off-by: Jason Frame <[email protected]>
… using full sync mode Signed-off-by: Jason Frame <[email protected]>
…into sync_no_tx_index_while_sync
pinges
approved these changes
Jan 31, 2025
| * @param block The block to append. | ||
| * @param receipts The list of receipts associated with this block's transactions. | ||
| */ | ||
| void appendBlockWithoutTxIndex(Block block, List<TransactionReceipt> receipts); |
There was a problem hiding this comment.
should that not be "appenBlockWithoutIndexingTxs" ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Disable transaction indexing during initial sync for snap and checkpoint sync. This does not disable transaction indexing for full nodes. It also keeps transaction indexing for near-head.
Chain download time for checkpoint sync using 4 with indexing and 4 without indexing on Azure Standard D4s v5 VMs.
Disk space comparison between indexed and non-indexed nodes
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests