New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #8204 by using BadBlockManager from protocol context #8207

Open

jflo wants to merge 1 commit into hyperledger:main from jflo:isolateBadBlockManager

+23 −28

Contributor

jflo commented Jan 30, 2025

fixes first part of #8204 by using BadBlockManager from protocol context


          fixes hyperledger#8204 by using BadBlockManager from protocol context

7d947d7

Signed-off-by: jflo <[email protected]>

jflo requested a review from matkt

January 30, 2025 20:43

macfarla approved these changes

View reviewed changes

Contributor

matkt commented Jan 31, 2025

did you had time to test it with a stateroot mismatch issue ? I saw on my last test that with a stateroot mismatch we are passing here https://github.com/hyperledger/besu/pull/8207/files#diff-e390f1feab110aff3f324e7e36e681b676198067f3b8932ff3abe97f0793df50R215 and in this case we are not adding the bad block

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet