Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] add newline to beginning of PR template #8210

Merged
merged 5 commits into from
Feb 2, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@

## PR description

## Fixed Issue(s)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,7 @@ public JsonRpcResponse syncResponse(final JsonRpcRequestContext requestContext)
.mapToInt(List::size)
.sum(),
lastExecutionTime / 1000.0,
executionResult.getNbParallelizedTransations());
executionResult.getNbParallelizedTransactions());
return respondWith(reqId, blockParam, newBlockHeader.getHash(), VALID);
} else {
if (executionResult.causedBy().isPresent()) {
Expand Down Expand Up @@ -612,7 +612,7 @@ private void logImportedBlockInfo(
final Block block,
final int blobCount,
final double timeInS,
final Optional<Integer> nbParallelizedTransations) {
final Optional<Integer> nbParallelizedTransactions) {
final StringBuilder message = new StringBuilder();
final int nbTransactions = block.getBody().getTransactions().size();
message.append("Imported #%,d (%s)|%5d tx");
Expand All @@ -635,9 +635,9 @@ private void logImportedBlockInfo(
(block.getHeader().getGasUsed() * 100.0) / block.getHeader().getGasLimit(),
timeInS,
mgasPerSec));
if (nbParallelizedTransations.isPresent()) {
if (nbParallelizedTransactions.isPresent()) {
double parallelizedTxPercentage =
(double) (nbParallelizedTransations.get() * 100) / nbTransactions;
(double) (nbParallelizedTransactions.get() * 100) / nbTransactions;
message.append("| parallel txs %5.1f%%");
messageArgs.add(parallelizedTxPercentage);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public class BlockProcessingResult extends BlockValidationResult {

private final Optional<BlockProcessingOutputs> yield;
private final boolean isPartial;
private Optional<Integer> nbParallelizedTransations = Optional.empty();
private Optional<Integer> nbParallelizedTransactions = Optional.empty();

/** A result indicating that processing failed. */
public static final BlockProcessingResult FAILED = new BlockProcessingResult("processing failed");
Expand All @@ -45,15 +45,15 @@ public BlockProcessingResult(final Optional<BlockProcessingOutputs> yield) {
* A result indicating that processing was successful but incomplete.
*
* @param yield the outputs of processing a block
* @param nbParallelizedTransations potential number of parallelized transactions during block
* @param nbParallelizedTransactions potential number of parallelized transactions during block
* processing
*/
public BlockProcessingResult(
final Optional<BlockProcessingOutputs> yield,
final Optional<Integer> nbParallelizedTransations) {
final Optional<Integer> nbParallelizedTransactions) {
this.yield = yield;
this.isPartial = false;
this.nbParallelizedTransations = nbParallelizedTransations;
this.nbParallelizedTransactions = nbParallelizedTransactions;
}

/**
Expand Down Expand Up @@ -166,7 +166,7 @@ public Optional<List<Request>> getRequests() {
*
* @return Optional of parallelized transactions during the block execution
*/
public Optional<Integer> getNbParallelizedTransations() {
return nbParallelizedTransations;
public Optional<Integer> getNbParallelizedTransactions() {
return nbParallelizedTransactions;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ public BlockProcessingResult validateAndProcessBlock(

return new BlockProcessingResult(
Optional.of(new BlockProcessingOutputs(worldState, receipts, maybeRequests)),
result.getNbParallelizedTransations());
result.getNbParallelizedTransactions());
}
} catch (MerkleTrieException ex) {
context.getWorldStateArchive().heal(ex.getMaybeAddress(), ex.getLocation());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ public EVM getEvm() {
}

/**
* Returns the TransctionReceiptFactory used in this specification
* Returns the TransactionReceiptFactory used in this specification
*
* @return the transaction receipt factory
*/
Expand Down
2 changes: 1 addition & 1 deletion testfuzz/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ BesuFuzz is where all the besu guided fuzzing tools live.

Performs differential fuzzing between Ethereum clients based on
the [txparse eofparse](https://github.com/holiman/txparse/blob/main/README.md#eof-parser-eofparse)
format. Note that only the inital `OK` and `err` values are used to determine if
format. Note that only the initial `OK` and `err` values are used to determine if
there is a difference.

### Prototypical CLI Usage:
Expand Down