Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Ensure Backward Sync Correctly Handles Finalized Block Hash #8217

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pr9t
Copy link
Contributor

@pr9t pr9t commented Feb 2, 2025

PR description

This PR addresses a bug where backwards sync should correctly handle the finalized block hash 0x0000..0000.

Added an if condition in MergeCoordinator.updateFinalized() to:

  • Check if the finalized block hash is 0x0000..0000.
  • Log a warning instead of trying to import an invalid block.
  • Return early to prevent unnecessary errors.

Fixed Issue(s)

fixes #7966

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@pr9t pr9t changed the title chore:solved backwards synch handle finalized code block has zero cor… Chore: Ensure Backward Sync Correctly Handles Finalized Block Hash Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backwards sync should handle finalized block hash 0x0000..0000 corrrectly
1 participant