Purge more stuff not necessary in FPC 1.0 (aka FPC Lite) #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
travis failed, not yet 100% sure why (i actually had tested locally a |
g2flyer
force-pushed
the
msteiner.more-tlcc-vlscc-purges
branch
from
1cdec76
to
537f812
Compare
g2flyer
force-pushed
the
msteiner.more-tlcc-vlscc-purges
branch
from
537f812
to
f8b3029
Compare
bvavala
reviewed
Dec 8, 2020
ecc_enclave/enclave/enclave.cpp
Outdated
| @@ -22,11 +22,6 @@ extern sgx_ec256_public_t enclave_pk; | |||
| // this is tlcc binding | |||
| sgx_ec256_public_t tlcc_pk = {0}; | |||
|
|
|||
| // TODO: replace with secure key generated in `common/enclave/cc_data.cpp` when we also create | |||
| // cc-encryption/decryption key-pair .. state encryption key; hardcoded for debugging | |||
| sgx_aes_gcm_128bit_key_t state_encryption_key = { | |||
There was a problem hiding this comment.
I guess you squashed a bit too much. Luckily it does not conflict!
There was a problem hiding this comment.
Arghh, good catch. turns out i screwed up in rebase and merged my changes into your commit (and also forgot to add some changes i had locally).
=> don't merge yet but wait for force-push below (and corresponding successful travis build)
bvavala
approved these changes
Dec 8, 2020
g2flyer
force-pushed
the
msteiner.more-tlcc-vlscc-purges
branch
from
f8b3029
to
e6d6a78
Compare
* tlcc* and validation plugins, some related fabric makefile stuff * demo, as not fpc-lite conformant * utils/docker-compose as not used without demo and anyway eventually made obsolete by test-network stuff once that's polished. This also removes the node-sdk code which was there somewhat out-of-place and also outdated and not really supported for now in FPC lite (note: look at `pre-fpc-lite` & `ccr2.0.0` if you want pre-fpc-lite/fpc 1.0 code with original trusted-ledger and validation code ...) Signed-off-by: Michael Steiner <[email protected]>
g2flyer
force-pushed
the
msteiner.more-tlcc-vlscc-purges
branch
from
e6d6a78
to
651c4ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
One step more along the agreement of last week to purge FPC "Full" stuff.
More specifically, it does remove tlcc* and validation plugins, some related fabric makefile stuff. It also removes
demoandutils/docker-compose(with the included but anyway outdated node-sdk code)Other potential clean-up actions which probably require further discussions:
ecc*. This needs coordination withecc-ecc_mockmerge; also seems to contain other obsolete code around "setup" and code inecc/crypto/obsoleted by new code ininternal...so we would have to replace it with something else, we cannot just remove it). There is now a separate issue FPC-1.0 conformant replacement for auction example/integration test #491 for that ....
common, e.g.,common/enclave, is really more and moreeccspecific and might better move there eventually. But certainly no priority and probably best done at a point we have to do anyway some refactoring with that code ...note: look at
pre-fpc-lite&ccr2.0.0if you want pre-fpc-lite/fpc 1.0 code with original trusted-ledger and validation code ...)Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing changes and/or breaks backward compatability?: