Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checking result of queryInstalled() #252

Merged
merged 6 commits into from
Aug 18, 2023

Conversation

jimthematrix
Copy link
Contributor

the label property has the value that is a combination of the chaincode name version. for instance if the chaincode name is basic, and version is v2.0, then the label is returned as basic_v2.0, using the convention _ to concatenate the two parts:

{
	"installed_chaincodes": [
		{
			"package_id": "firefly_1.0:b8e754685421dd03e40251b9ef2dd811e49659453cd489ca7bd27585d9be06b4",
			"label": "firefly_1.0",
			"references": {
				"firefly": {
					"chaincodes": [
						{
							"name": "firefly",
							"version": "1.0"
						}
					]
				}
			}
		},
		{
			"package_id": "basic_v1.0:351b39eb21c6a1d42f65d21398bf747880404c322a8883f2fb61fe1a3bb0d68d",
			"label": "basic_v1.0"
		}
	]
}

Copy link
Contributor

@nguyer nguyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and fixing this, @jimthematrix!

@nguyer nguyer merged commit 0829455 into hyperledger:main Aug 18, 2023
11 of 12 checks passed
@nguyer nguyer deleted the fix-query-installed-cc branch August 18, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants