Provide the client certificate without relying on golang matching it #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from a list Signed-off-by: Enrique Lacal <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #152 +/- ##
=======================================
Coverage 99.80% 99.80%
=======================================
Files 82 82
Lines 6646 6672 +26
=======================================
+ Hits 6633 6659 +26
Misses 12 12
Partials 1 1 ☔ View full report in Codecov by Sentry. |
peterbroadhurst
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed when providing the client certificates to ffresty, it wasn't getting being passed on the API call itself and it's due to Golang not matching that cert based on the requirements of the request.
Some background https://forum.golangbridge.org/t/issue-with-client-tls-authentication/8214