[pkg/metric] - Add the ability to register a new metrics collector to the registry #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cari Albritton <[email protected]>
onelapahead
reviewed
Oct 24, 2024
There was a problem hiding this comment.
Looks great to me, just some small nits. Will defer to @EnriqueL8 @shorsher for a review.
Signed-off-by: Cari Albritton <[email protected]>
Signed-off-by: Cari Albritton <[email protected]>
peterbroadhurst
approved these changes
Oct 24, 2024
Signed-off-by: Cari Albritton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding RegisterCollector to support adding a custom prometheus Collector to the prometheus Metrics Registry. Currently
MetricsRegistryonly allows creating a registry with the default GoCollector and ProcessCollector.