Handle large numbers when unmarshalling to an operation #1581
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1568
When unmarshalling contract invoke payloads to a Firefly
operation
, unmarshal numbers tojson.Number
instead offloat64
. This avoids unexpected (and silent) precision loss if a large number is included in the input payload.I've tested this locally in a FF stack:
curl
request to invoke a contract's setter function with a very large number:input
of the FF response matches the request:event
from the blockchain comes back correctly: