-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add E2E test support for ERC20/ERC721 #611
Conversation
Because some token transactions may generate events of multiple types (such as a transfer triggering approval changes as a side effect), the transaction type must be stored instead of being inferred from the event. Signed-off-by: Andrew Richardson <[email protected]>
Resolves hyperledger#564 Signed-off-by: Andrew Richardson <[email protected]>
I attempted to add ERC20/ERC721 tokens to the E2E matrix for GitHub PRs - will see if it works and runs here. Open to whether this is needed or not (obviously we only want to run a subset of all combinations on every PR). |
Codecov Report
@@ Coverage Diff @@
## main #611 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 305 305
Lines 18196 18266 +70
=========================================
+ Hits 18196 18266 +70
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor thing on the GitHub action, but other than that, looks good
And there's a failing E2E test 😕 |
It's weird that Fabric + ERC1155 even executes (and passes?)... does it just ignore the token provider? I know it's definitely not actually using it. And yea the failures in ERC20 are expected until the dependent PR noted is merged and tagged in the manifest. |
Opened hyperledger/firefly-cli#162 to track the fact that |
Signed-off-by: Andrew Richardson <[email protected]>
Signed-off-by: Andrew Richardson <[email protected]>
Signed-off-by: Andrew Richardson <[email protected]>
Depends on hyperledger/firefly-tokens-erc20-erc721#33