Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Validate PR title #170

Merged
merged 1 commit into from
May 31, 2024
Merged

ci: Validate PR title #170

merged 1 commit into from
May 31, 2024

Conversation

hamada147
Copy link
Contributor

Description:

Add PR title validation to be in line with conventional commits.

Alternatives Considered (optional):

Link to existing ADR (Architecture Decision Record), if any. If relevant, describe other approaches explored and the selected approach. Documenting why the methods were not selected will create a knowledge base for future reference, helping prevent others from revisiting less optimal ideas.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

Signed-off-by: Ahmed Moussa <[email protected]>
@atala-dev
Copy link
Contributor

Code Coverage

Total Project Coverage 88.93%

@hamada147 hamada147 merged commit e92d5b9 into main May 31, 2024
2 checks passed
@hamada147 hamada147 deleted the ci/add-pr-title-validation branch May 31, 2024 16:41
todorkoleviohk added a commit that referenced this pull request Jun 2, 2024
…ter)

ci: Validate PR title (#170)

Signed-off-by: Ahmed Moussa <[email protected]>

syncing with main and applying the change there too

squashing

squashing
@atala-dev
Copy link
Contributor

🎉 This PR is included in version 1.3.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants