Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(secp256k1): add library to be our dependency for secp256k1 in js #75

Closed
wants to merge 2 commits into from
Closed

feat(secp256k1): add library to be our dependency for secp256k1 in js #75

wants to merge 2 commits into from

Conversation

goncalo-frade-iohk
Copy link
Contributor

@goncalo-frade-iohk goncalo-frade-iohk commented Jul 5, 2023 •
edited by jira bot
Loading

@atala-dev
Copy link
Contributor

atala-dev commented Jul 5, 2023 •
edited
Loading

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 4 0 0.03s
✅ KOTLIN ktlint 3 0 7.99s
⚠️ REPOSITORY devskim yes 6 0.97s
✅ REPOSITORY dustilock yes no 0.07s
✅ REPOSITORY gitleaks yes no 1.58s
✅ REPOSITORY git_diff yes no 0.02s
✅ REPOSITORY secretlint yes no 3.13s
✅ REPOSITORY syft yes no 0.29s
✅ REPOSITORY trivy yes no 5.44s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

cristianIOHK
cristianIOHK approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@cristianIOHK cristianIOHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

hamada147
hamada147 approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@hamada147 hamada147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goncalo-frade-iohk
Copy link
Contributor Author

Ive closed this PR since I made a mistake a rebased this commit on my next one.

@hamada147 hamada147 deleted the feature/ATL-5163 branch May 31, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianIOHK cristianIOHK cristianIOHK approved these changes

@hamada147 hamada147 hamada147 approved these changes

@elribonazo elribonazo Awaiting requested review from elribonazo

@curtis-h curtis-h Awaiting requested review from curtis-h

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@goncalo-frade-iohk @atala-dev @hamada147 @cristianIOHK