Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add oid4vci negative scenario tests #1380

Merged
merged 8 commits into from
Oct 2, 2024
Merged

test: add oid4vci negative scenario tests #1380

merged 8 commits into from
Oct 2, 2024
+280 −69

Conversation

amagyar-iohk
Copy link
Contributor

Description:

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 26, 2024 •
edited
Loading

Unit Test Results

102 files  ±0  102 suites  ±0   19m 52s ⏱️ ±0s
874 tests ±0  866 ✅ ±0  8 💤 ±0  0 ❌ ±0 
881 runs  ±0  873 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit 6053514. ± Comparison against base commit ad946cf.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Sep 26, 2024 •
edited
Loading

Coverage Status

coverage: 48.653%. remained the same
when pulling 6053514 on test/oid4vci
into ad946cf on main.

patlo-iog
patlo-iog reviewed Sep 27, 2024
View reviewed changes
tests/integration-tests/src/test/resources/features/oid4vci/manage_issuer.feature Outdated
Examples:
| id | url | clientId | clientSecret | httpStatus | errorDetail | description |
| null | null | null | null | 400 | authorizationServer.url | null values |
| null | malformed | id | secret | 400 | Invalid URL | malformed url |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

malforrmed is actually a valid URL. We should repurpose this case to Disallow relative URL

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patlo-iog, I saw you already Disallow the relative URL is the latest PR

@github-actions @hyperledger-bot
style: apply linters automatic fixes (#1387)
6053514 
Signed-off-by: Hyperledger Bot <[email protected]>
Co-authored-by: Hyperledger Bot <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Integration Test Results

20 files  ± 0  20 suites  ±0   2s ⏱️ ±0s
49 tests + 4  49 ✅ + 4  0 💤 ±0  0 ❌ ±0 
88 runs  +17  88 ✅ +17  0 💤 ±0  0 ❌ ±0 

Results for commit 6053514. ± Comparison against base commit ad946cf.

@amagyar-iohk amagyar-iohk marked this pull request as ready for review October 2, 2024 19:00
@amagyar-iohk amagyar-iohk requested a review from a team as a code owner October 2, 2024 19:00
@amagyar-iohk amagyar-iohk merged commit 7b4a9c1 into main Oct 2, 2024
16 checks passed
@amagyar-iohk amagyar-iohk deleted the test/oid4vci branch October 2, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yshyn-iohk yshyn-iohk yshyn-iohk approved these changes

@patlo-iog patlo-iog patlo-iog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amagyar-iohk @coveralls @yshyn-iohk @patlo-iog