fix: key id for jwt and sdjwt #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mineme0110
changed the title
yshyn-iohk
reviewed
Oct 29, 2024
| @@ -120,7 +120,13 @@ object CredentialServiceError { | |||
| StatusCode.NotFound, | |||
| s"A key with the given purpose was not found in the DID: did=${did.toString}, purpose=${verificationRelationship.name}" | |||
| ) | |||
|
|
|||
| final case class MultipleKeysWithSamePurposeFoundInDID( | |||
There was a problem hiding this comment.
@mineme0110, is it possible to keep two keys (secp256 and de25519) with the same purpose?
There was a problem hiding this comment.
Yes it is possible to have multiple keys with same purpose as per the spec
yshyn-iohk
reviewed
Oct 29, 2024
.../core/src/main/scala/org/hyperledger/identus/pollux/core/service/CredentialServiceImpl.scala
Show resolved
Hide resolved
Signed-off-by: mineme0110 <[email protected]>
mineme0110
force-pushed
the
feat/keyid-jwt-sdjwt
branch
from
fdf127c
to
9b74fbf
Compare
Signed-off-by: mineme0110 <[email protected]>
Signed-off-by: mineme0110 <[email protected]>
Signed-off-by: Hyperledger Bot <[email protected]> Co-authored-by: Hyperledger Bot <[email protected]>
Signed-off-by: mineme0110 <[email protected]>
Signed-off-by: mineme0110 <[email protected]>
Signed-off-by: Hyperledger Bot <[email protected]> Co-authored-by: Hyperledger Bot <[email protected]>
…entus-cloud-agent into feat/keyid-jwt-sdjwt
Signed-off-by: mineme0110 <[email protected]> scalafmt Signed-off-by: mineme0110 <[email protected]> Updated unit test to support kid Signed-off-by: mineme0110 <[email protected]> OIDC feature doesnt have kid support in JWT Signed-off-by: mineme0110 <[email protected]> style: apply linters automatic fixes (#1425) Signed-off-by: Hyperledger Bot <[email protected]> Co-authored-by: Hyperledger Bot <[email protected]> Add new keyid test for JWT with ED25519 signed credential Signed-off-by: mineme0110 <[email protected]>
mineme0110
force-pushed
the
feat/keyid-jwt-sdjwt
branch
from
ee45e5a
to
4f36468
Compare
Signed-off-by: mineme0110 <[email protected]>
Signed-off-by: mineme0110 <[email protected]>
bytewizard42i
pushed a commit
to bytewizard42i/identus-cloud-agent
that referenced
this pull request
Nov 13, 2024
# [1.40.0](hyperledger/identus-cloud-agent@cloud-agent-v1.39.0...cloud-agent-v1.40.0) (2024-11-05) ### Bug Fixes * Add key_id missing field ([hyperledger#1403](hyperledger#1403)) ([cbd1a03](hyperledger@cbd1a03)) * adjust Kotlin and TypeScript HTTP client to use the `schemaId` f… ([hyperledger#1388](hyperledger#1388)) ([c2da492](hyperledger@c2da492)) * cannot reuse the same credential-offer in oid4vci ([hyperledger#1361](hyperledger#1361)) ([6a0a3ea](hyperledger@6a0a3ea)) * handle unsupported PIURI found in DIDComm messages accordingly ([hyperledger#1399](hyperledger#1399)) ([9b64793](hyperledger@9b64793)) * key id for jwt and sdjwt ([hyperledger#1420](hyperledger#1420)) ([5830a7e](hyperledger@5830a7e)) * oas to use any schema for json ast node ([hyperledger#1372](hyperledger#1372)) ([95d328e](hyperledger@95d328e)) * oid4vci endpoints error statuses and negative input validation ([hyperledger#1384](hyperledger#1384)) ([65cc9a7](hyperledger@65cc9a7)) * Preserve Presentation Format ([hyperledger#1363](hyperledger#1363)) ([c18385c](hyperledger@c18385c)) * return 404 when create credConfig on non-existing issuer ([hyperledger#1379](hyperledger#1379)) ([e532ba6](hyperledger@e532ba6)) ### Features * Add KID to the credential-offers API - ATL-7704 ([hyperledger#1320](hyperledger#1320)) ([56200cf](hyperledger@56200cf)) * add presentation-exchange endpoints ([hyperledger#1365](hyperledger#1365)) ([49f7ab3](hyperledger@49f7ab3)) * ATL-6983 ZIO Stream Kafka PoC in background jobs ([hyperledger#1339](hyperledger#1339)) ([19ab426](hyperledger@19ab426)) * Default Backend API to Array Of Credential Schema ([hyperledger#1366](hyperledger#1366)) ([693dcc4](hyperledger@693dcc4)) * Default Object As Issuer ([hyperledger#1349](hyperledger#1349)) ([d29eebb](hyperledger@d29eebb)) * Implement prism anoncreds method for schemas and credential definitions ([hyperledger#1385](hyperledger#1385)) ([fbee055](hyperledger@fbee055)) * Issuer Replace Either By Union Type ([hyperledger#1374](hyperledger#1374)) ([8fc2fe3](hyperledger@8fc2fe3)) * presentation_submission validation logic ([hyperledger#1332](hyperledger#1332)) ([f80b3c3](hyperledger@f80b3c3)) * Support Array Of Credential Schema ([hyperledger#1351](hyperledger#1351)) ([948e314](hyperledger@948e314)) * Test JWT OBJECT as Issuer ([hyperledger#1343](hyperledger#1343)) ([7208d95](hyperledger@7208d95)) * VC support for Array of credential Status ([hyperledger#1383](hyperledger#1383)) ([ad946cf](hyperledger@ad946cf)) * VCVerification API support ARRAY or OBJECT as Credential Sc… ([hyperledger#1355](hyperledger#1355)) ([91cb4e7](hyperledger@91cb4e7)) [skip ci] Signed-off-by: Hyperledger Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The key ID (kid) should be used to select the correct key when multiple keys with the same purpose, such as ED25519 and SECP256K1, are available for JWT issuance. For SDJWT, only ED25519 is supported for now. This change will enable the agent to issue JWTs in both formats, with the header containing the appropriate kid value
Checklist: