Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proof presentation request #1453

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

mineme0110
Copy link
Contributor

@mineme0110 mineme0110 commented Nov 18, 2024

Description:

#1438
Add validation for schemaId and trusted issuer

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@mineme0110 mineme0110 requested a review from a team as a code owner November 18, 2024 16:06
Copy link
Contributor

github-actions bot commented Nov 19, 2024

Unit Test Results

104 files  +1  104 suites  +1   21m 15s ⏱️ + 1m 26s
882 tests +5  874 ✅ +5  8 💤 ±0  0 ❌ ±0 
889 runs  +5  881 ✅ +5  8 💤 ±0  0 ❌ ±0 

Results for commit 1d70e4d. ± Comparison against base commit b0effec.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Nov 19, 2024

Coverage Status

coverage: 48.854% (+0.05%) from 48.809%
when pulling 1d70e4d on fix/proof-presentation-request
into b0effec on main.

Copy link
Member

@yshyn-iohk yshyn-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job, @mineme0110
is it possible to add a couple of tests?

Signed-off-by: mineme0110 <[email protected]>
…rledger/identus-cloud-agent into fix/proof-presentation-request
Copy link
Contributor

github-actions bot commented Nov 19, 2024

Integration Test Results

20 files  ±0  20 suites  ±0   3s ⏱️ ±0s
54 tests +1  54 ✅ +1  0 💤 ±0  0 ❌ ±0 
95 runs  +1  95 ✅ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 1d70e4d. ± Comparison against base commit b0effec.

♻️ This comment has been updated with latest results.

@amagyar-iohk
Copy link
Contributor

@mineme0110 does this PR also updates the /present-proof/presentations/$presentationId endpoint to return the requested proofs?

Right know when we have a proof request there's no information on holder side of what's being requested.

Holder webhook data:

PresentationStatusAdapter(presentationId=94acbe0f-ed87-4477-9757-4b4ba8c3461d, thid=d080d2b5-0498-42aa-a829-22cf021ff3cf, role=PROVER, status=REQUEST_RECEIVED, metaRetries=5, proofs=[], data=[], connectionId=null)

GET /present-proof/presentations/$presentationId

{
    "presentationId": "94acbe0f-ed87-4477-9757-4b4ba8c3461d",
    "thid": "d080d2b5-0498-42aa-a829-22cf021ff3cf",
    "role": "Prover",
    "status": "RequestReceived",
    "proofs": [
        
    ],
    "data": [
        
    ],
    "requestData": [
        "{\n  \"options\" : {\n    \"domain\" : \"https://example-verifier.com\",\n    \"challenge\" : \"11c91493-01b3-4c4d-ac36-b336bab5bddf\"\n  },\n  \"presentation_definition\" : {\n    \"format\" : null,\n    \"name\" : null,\n    \"purpose\" : null,\n    \"id\" : \"345b056f-2889-458a-9f59-25d1ab249557\",\n    \"input_descriptors\" : [\n    ]\n  }\n}"
    ],
    "metaRetries": 5
}

Signed-off-by: mineme0110 <[email protected]>
@mineme0110
Copy link
Contributor Author

@ALL

@mineme0110 does this PR also updates the /present-proof/presentations/$presentationId endpoint to return the requested proofs?

Right know when we have a proof request there's no information on holder side of what's being requested.

Holder webhook data:

PresentationStatusAdapter(presentationId=94acbe0f-ed87-4477-9757-4b4ba8c3461d, thid=d080d2b5-0498-42aa-a829-22cf021ff3cf, role=PROVER, status=REQUEST_RECEIVED, metaRetries=5, proofs=[], data=[], connectionId=null)

GET /present-proof/presentations/$presentationId

{
    "presentationId": "94acbe0f-ed87-4477-9757-4b4ba8c3461d",
    "thid": "d080d2b5-0498-42aa-a829-22cf021ff3cf",
    "role": "Prover",
    "status": "RequestReceived",
    "proofs": [
        
    ],
    "data": [
        
    ],
    "requestData": [
        "{\n  \"options\" : {\n    \"domain\" : \"https://example-verifier.com\",\n    \"challenge\" : \"11c91493-01b3-4c4d-ac36-b336bab5bddf\"\n  },\n  \"presentation_definition\" : {\n    \"format\" : null,\n    \"name\" : null,\n    \"purpose\" : null,\n    \"id\" : \"345b056f-2889-458a-9f59-25d1ab249557\",\n    \"input_descriptors\" : [\n    ]\n  }\n}"
    ],
    "metaRetries": 5
}

@amagyar-iohk No it doesn't I think we should raise a new issue

mineme0110 and others added 3 commits November 20, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants