Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docker image, add indy-vdr to deps #69

Merged

Conversation

mrkaurelius
Copy link
Contributor

No description provided.

@mrkaurelius
Copy link
Contributor Author

Related to #68

@WadeBarnes WadeBarnes self-requested a review February 1, 2024 12:24
@WadeBarnes WadeBarnes self-assigned this Feb 1, 2024
@WadeBarnes WadeBarnes added the code review Code Review label Feb 22, 2024
@WadeBarnes
Copy link
Member

WadeBarnes commented Mar 14, 2024

@mrkaurelius, I took the opportunity to remove the references to the bcgovimages/von-image images. I've been meaning to do that for some time now. It will be more maintainable moving forward to use an official python base image. Let me know what you think. If this works for you, I'd recommend you squash our changes together and then I can merge.

I retained all the k8s/openshift compatible features from the bcgovimages/von-image images.

Signed-off-by: Abdulhamit Kumru <[email protected]>

Remove references to bcgovimages/von-image

- Switch base image to a plain python image for better maintainability.

Signed-off-by: Wade Barnes <[email protected]>

Fix issue with telegraf.conf

- telegraf expects a trailing linefeed

Signed-off-by: Wade Barnes <[email protected]>
@mrkaurelius mrkaurelius force-pushed the fix-fetch-validator-status-deps branch from 4c092d6 to e267a02 Compare March 19, 2024 07:12
@mrkaurelius
Copy link
Contributor Author

Hi @WadeBarnes. Using official python image is could be more sensible 👍

@WadeBarnes WadeBarnes merged commit 1c20c07 into hyperledger:main Mar 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code review Code Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants