Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Updates #1814

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

pSchlarb
Copy link
Contributor

@pSchlarb pSchlarb commented Apr 24, 2023

Cherry picked the New Network from Scratch documentation,
updated the indy-cli references to include indy-cli-rs
and fixed the Python3.5 reference as pointed out in #1811.

Feel free to make changes to this PR, which is open for edits.

Added Documentation for creating a new Network

(cherry picked from commit fe1632e)
Signed-off-by: Philipp Schlarb <[email protected]>
Signed-off-by: Philipp Schlarb <[email protected]>
@pSchlarb pSchlarb requested a review from a team as a code owner April 24, 2023 10:32
@WadeBarnes
Copy link
Member

@lynnbendixsen, Could you review the documentation please. Focusing on docs/source/configuring-2nics.md and docs/source/installation-and-configuration.md since the configuration of the NICs is different on Ubuntu 20.04 and the package installation for 20.04 requires a few more steps at the moment.

@WadeBarnes
Copy link
Member

@pSchlarb, I think we should switch to indy-cli-rs as the recommended cli if not using the containerized one from von-network.

@pSchlarb
Copy link
Contributor Author

pSchlarb commented Apr 24, 2023

Yeah sure I can change it, but I would walk through it myself first to see if it works. Not sure if I can finish that before tomorrows contributors call.

@WadeBarnes
Copy link
Member

Yeah sure I can change it, but I would walk through it myself first to see if it works. Not sure if I can finish that before todays contributors call.

You'll find the installation is a bit different.

Signed-off-by: Philipp Schlarb <[email protected]>
@pSchlarb
Copy link
Contributor Author

pSchlarb commented May 4, 2023

Just testet the documentation with indy-cli-rs it works fine. Should the old indy-cli install be deleted from the docs in all and only reference indy-cli-rs or bundled von network?

@WadeBarnes
Copy link
Member

Just testet the documentation with indy-cli-rs it works fine. Should the old indy-cli install be deleted from the docs in all and only reference indy-cli-rs or bundled von network?

Yes, you can remove the references to the indy-sdk based version of the indy-cli and just leave the indy-cli-rs and von-network references.

swcurran
swcurran previously approved these changes May 9, 2023
@swcurran
Copy link
Member

swcurran commented May 9, 2023

@WadeBarnes — leaving this to merge for you. Looks good, but I didn’t walk through it...

Signed-off-by: Philipp Schlarb <[email protected]>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This document needs to be updated with the steps using netplan on Ubuntu 20.04. @lynnbendixsen, would you be able to lend your updated wording to this document?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The installation section needs to be updated with the Ubuntu 20.04 instructions. I can look into that.


Initial Trustees (3 preferred) must create and submit a Trustee DID and Verkey so that the domain genesis file can be built.

Each trustee has to [instal the `indy-cli`](./CLIInstall.md) and [create a Trustee DID](./CreateDID.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instal should be install here


A Steward is an organization responsible for running a Node on the Network

Exactly 4 “Genesis” Stewards are needed to establish the network, more Stewards can be added later.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend changing this to:
"Exactly 4 “Genesis” Stewards are required to establish the network, but at least 7 are recommended for a production network that you expect to last for a long time. More Stewards can be added later.

1. Determine a name for the new network and have the stewards substitute it in the appropriate places in the guide, such as when setting the network name and creating the directory when creating the keys for the node.
1. They all need to stop at the normal place ([3.5. Add Node to a Pool](../installation-and-configuration.md#3.5.-Add-Node-to-a-Pool)) as instructed in the guide as the steps that follow differ when creating a new network. The following sections of this guide describe the steps required to start the new network.

Once the Stewards have created their DID and Verkey, and performed the initial setup of they node, give the Stewards access to a spreadsheet like [this one](https://docs.google.com/spreadsheets/d/1LDduIeZp7pansd9deXeVSqGgdf0VdAHNMc7xYli3QAY/edit#gid=0) and have them fill out their own row of the Stewards sheet. The completed sheet will be used to generate the genesis transaction files for the network.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"setup of they node" should be "setup of their node"

Signed-off-by: pSchlarb <[email protected]>
@WadeBarnes
Copy link
Member

@lynnbendixsen, Could you have a look at the NIC configuration and update it as needed for Ubuntu 20.04 (to use netplan)?

@lynnbendixsen
Copy link
Contributor

lynnbendixsen commented May 21, 2024

I am wondering if it's best to remove the "configuring-2nics.md" file, or maybe shortening it to just include a single line like 'To configure 2 nics refer to the platform specific instructions included as part of the *-NodeInstall-20.04.md documents included in the indy-node/docs/source/install-docs directory']
Reasoning:
The configuring-2nics file focuses on AWS instructions only
All relevant instructions for each of the other platforms is already written and included in the referenced documents.
Thoughts?
EDIT: The same as the above is likely true for the "installation-and-configuration.md" document. I have checked in a "validator-prep-20.04.md" document to the same director (install-docs).
Apologies for not seeing that documents already existed and then using those when I added the install documents last year. My bad. I will keep looking through the docs and see what can be done to either use, merge, or adjust these previously made documents to make it so that all is coherent. At least a master document is still needed (probably use installation-and-configuration.md?) that can guide newcomers through the process and link to the documents needed for each platform.

@WadeBarnes
Copy link
Member

Yes, take advantage of the additional documentation and reference it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants