feat: added improved gh actions #293

wadeking98 · 2024-05-29T23:31:23Z

Added github actions to automatically publish alpha versions to npm.
Included binaries in react native package so we have a smoother release cycle without having to wait for a binary release

This PR does not effect the usual release cycle, this only adds alpha releases. Normal major releases will still have to be triggered manually

Signed-off-by: wadeking98 <[email protected]>

.github/workflows/build.yml

Signed-off-by: wadeking98 <[email protected]>

.github/workflows/build.yml

Signed-off-by: wadeking98 <[email protected]>

jleach · 2024-05-30T16:38:17Z

.github/workflows/build.yml

+      run:
+        working-directory: ./wrappers/javascript
+    timeout-minutes: 7
+    steps:


A few spaces won't change much but make make it easier for the eye to follow. Between steps?

berendsliedrecht · 2024-05-30T17:16:37Z

wrappers/javascript/indy-vdr-react-native/package.json

@@ -54,12 +53,5 @@
  "peerDependencies": {
    "react": ">= 16",
    "react-native": ">= 0.66.0"
-  },
-  "binary": {


Won't this break the non-alpha releases? My preference would really be to fetch the libraries from gh in a post install (what node-pre-gyp does), but if there are benefits I am okay with it.

I got rid of this because the new github actions copy the compiled binaries into the native folder, so the alpha release will target the latest binaries

we can go back to fetch when/if we can figure out publishing alpha releases of the rust libraries. I was thinking on maybe publishing alphas builds to GitHub Package Registry (maybe as maven artifacts)

I got rid of this because the new github actions copy the compiled binaries into the native folder, so the alpha release will target the latest binaries

but it only does this in the alpha-release action, correct? Normal releases will not contain the copied library and fail as we also do not push them to the repository.

we can go back to fetch when/if we can figure out publishing alpha releases of the rust libraries. I was thinking on maybe publishing alphas builds to GitHub Package Registry (maybe as maven artifacts)

I would stay away from maven artifacts, or pods, as it will change the setup process quite a bit. Might be a nice end goal, but for now just including the xcframework and android libraries like so is fine.

For rust alpha releases, something like 0.1.0-alpha.1 will work on crates.io.

Honestly i don't see a reason to change this setup?

It works cross platform for Node.JS / iOS / Android and means you only download the binary for your platform (in the Node.JS release)

We've put quite some thought into this process and I would be really disappointed to see it replaced by something else that caters better to your use case (react native), but doesn't take into account Node.Js

See my suggestion on how to approach this in the other comment

Signed-off-by: wadeking98 <[email protected]>

cvarjao · 2024-06-04T17:35:58Z

@andrewwhitehead , @berendsliedrecht , can we get this merged for us to be able to get alpha release for the react native wrapper?

andrewwhitehead · 2024-06-05T04:01:11Z

wrappers/javascript/indy-vdr-react-native/package.json

  },
  "dependencies": {
-    "@hyperledger/indy-vdr-shared": "0.2.0-dev.6",
-    "@mapbox/node-pre-gyp": "^1.0.10"
+    "@hyperledger/indy-vdr-shared": "0.2.0-dev.6"


I believe this needs updating to 0.2.2?

TimoGlastra · 2024-06-06T06:28:31Z

Included binaries in react native package so we have a smoother release cycle without having to wait for a binary release

It is generally not advised to push such big binaries to the NPM registry. Also because it means you download the binaries for all platforms when you install the package rather than just the binary for your platform.

So from my side this would be a No to merging this PR as is. Maybe we can look at creating pre-releases on github, so that we download the binary and not have to include it in the package.

TimoGlastra · 2024-06-06T06:35:51Z

.github/workflows/build.yml

+    needs: 
+      - create-ios-xcframework
+      - create-android-library


This seems to just release the ios/android wrappers as alpha. Not the Node.JS.

I would really like to keep consistency between node.js and react native.

My proposal for this PR would be:

on push to main, build the binaries for indy vdr

update the version of the wrapper to the current package.json version but with e.g. .alpha-{commit-sha} appended

create a prerelease on github and push the binaries

release the JS wrapper

The github pre releaase could e.g. be called "JS 0.2.2 Alpha {sha-commit}" to make it clear this is a JS pre-release.

Then the package.json binary is updated to link to this pre-release.

This way pre-releases work the same as normal releases.

It seems messy to manage different lifecycle in the same repository. I think we need to move to uniffi-rs or some other tool. I am concern about those wrappers getting out of sync, missing releases, and release from side branches, like we it was done.

TimoGlastra · 2024-06-06T06:37:27Z

.github/workflows/build.yml

+        run: |
+          git update-index --assume-unchanged $(find . -type d -name node_modules -prune -o -name 'package.json' -print | tr "\n" " ")
+          #export NEXT_VERSION_BUMP=$(yarn next-version-bump)
+          export NEXT_VERSION_BUMP="major"


This will always increase the version by major, not sure if that's what we want?

Maybe we can just do the current version + alpha-{commit-sha}?

TimoGlastra · 2024-06-06T06:37:48Z

wrappers/javascript/indy-vdr-react-native/package.json

@@ -28,6 +28,7 @@
    "ios/indyVdr.xcodeproj/project.pbxproj",
    "cpp/**/*.cpp",
    "cpp/**/*.h",
+    "native/**",


This should not be published

TimoGlastra · 2024-06-06T06:39:14Z

wrappers/javascript/indy-vdr-react-native/package.json

@@ -54,12 +53,5 @@
  "peerDependencies": {
    "react": ">= 16",
    "react-native": ">= 0.66.0"
-  },
-  "binary": {


Honestly i don't see a reason to change this setup?

It works cross platform for Node.JS / iOS / Android and means you only download the binary for your platform (in the Node.JS release)

We've put quite some thought into this process and I would be really disappointed to see it replaced by something else that caters better to your use case (react native), but doesn't take into account Node.Js

wadeking98 added 2 commits May 29, 2024 16:29

update github actions

a2a453b

Signed-off-by: wadeking98 <[email protected]>

updated actions to production values

f725a4e

Signed-off-by: wadeking98 <[email protected]>

andrewwhitehead reviewed May 29, 2024

View reviewed changes

.github/workflows/build.yml Outdated Show resolved Hide resolved

update action check

dba3f53

Signed-off-by: wadeking98 <[email protected]>

wadeking98 requested a review from andrewwhitehead May 30, 2024 01:02

cvarjao suggested changes May 30, 2024

View reviewed changes

.github/workflows/build.yml Outdated Show resolved Hide resolved

install immutable

7f7be6a

Signed-off-by: wadeking98 <[email protected]>

jleach reviewed May 30, 2024

View reviewed changes

berendsliedrecht reviewed May 30, 2024

View reviewed changes

wadeking98 requested review from jleach, berendsliedrecht and cvarjao May 30, 2024 21:10

updated version in lerna config

36c30a5

Signed-off-by: wadeking98 <[email protected]>

andrewwhitehead reviewed Jun 5, 2024

View reviewed changes

TimoGlastra requested changes Jun 6, 2024

View reviewed changes

wadeking98 closed this Jun 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: added improved gh actions #293

feat: added improved gh actions #293

wadeking98 commented May 29, 2024 •

edited

Loading

jleach May 30, 2024

berendsliedrecht May 30, 2024

wadeking98 May 30, 2024

cvarjao May 31, 2024

berendsliedrecht Jun 5, 2024 •

edited

Loading

TimoGlastra Jun 6, 2024

TimoGlastra Jun 6, 2024

cvarjao commented Jun 4, 2024

andrewwhitehead Jun 5, 2024

TimoGlastra commented Jun 6, 2024

TimoGlastra Jun 6, 2024

TimoGlastra Jun 6, 2024

cvarjao Jun 6, 2024 •

edited

Loading

TimoGlastra Jun 6, 2024

TimoGlastra Jun 6, 2024

TimoGlastra Jun 6, 2024

feat: added improved gh actions #293

feat: added improved gh actions #293

Conversation

wadeking98 commented May 29, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

berendsliedrecht Jun 5, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cvarjao commented Jun 4, 2024

Choose a reason for hiding this comment

TimoGlastra commented Jun 6, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cvarjao Jun 6, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wadeking98 commented May 29, 2024 •

edited

Loading

berendsliedrecht Jun 5, 2024 •

edited

Loading

cvarjao Jun 6, 2024 •

edited

Loading