Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] #3088: Introduce queue throttling #3563

Merged
merged 2 commits into from
Jun 5, 2023

Conversation

Erigara
Copy link
Contributor

@Erigara Erigara commented Jun 5, 2023

Description

Instead of introducing separate queue for MST transaction and double required space for queue.
It was decided to approach problem from different angle and restrict amount of transactions user can have pending in the queue.

Linked issue

Closes #3088

Benefits

Single user can't flood transaction queue.

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@Erigara Erigara added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Jun 5, 2023
@Erigara Erigara requested a review from s8sato as a code owner June 5, 2023 09:43
@Erigara Erigara self-assigned this Jun 5, 2023
@appetrosyan appetrosyan self-assigned this Jun 5, 2023
appetrosyan
appetrosyan previously approved these changes Jun 5, 2023
core/src/queue.rs Show resolved Hide resolved
core/src/queue.rs Outdated Show resolved Hide resolved
core/src/queue.rs Outdated Show resolved Hide resolved
@appetrosyan appetrosyan merged commit 0a9fc8e into hyperledger:iroha2-dev Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants