Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Bump rust toolchain to nightly-2024-09-09 #5047

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

BAStos525
Copy link
Member

Context

Bump rust toolchain to nightly-2024-09-09 in iroha2 CI.

Solution

Closes #5045

Checklist

  • I've read CONTRIBUTING.md.
  • (optional) I've written unit tests for the code changes.
  • All review comments have been resolved.
  • All CI checks pass.

@mversic
Copy link
Contributor

mversic commented Sep 9, 2024

update wasm_builder/src/lib.rs also

@mversic mversic force-pushed the ci/bump-toolchain-09-09-24 branch 9 times, most recently from d7539b6 to 69777cc Compare September 10, 2024 03:52
@mversic mversic enabled auto-merge (squash) September 10, 2024 03:55
mversic
mversic previously approved these changes Sep 10, 2024
@mversic mversic self-assigned this Sep 10, 2024
@DCNick3
Copy link
Contributor

DCNick3 commented Sep 10, 2024

How about we commit a rust-toolchain.toml file so that the developers get the rust version corresponding to what we have in CI right away?

[toolchain]
channel = "nightly-2024-09-09"

primitives/src/addr.rs Outdated Show resolved Hide resolved
@mversic
Copy link
Contributor

mversic commented Sep 10, 2024

How about we commit a rust-toolchain.toml file so that the developers get the rust version corresponding to what we have in CI right away?

[toolchain]
channel = "nightly-2024-09-09"

opened #5051

@mversic mversic force-pushed the ci/bump-toolchain-09-09-24 branch 2 times, most recently from 5be1d45 to 2172286 Compare September 10, 2024 07:12
mversic
mversic previously approved these changes Sep 10, 2024
@nxsaken
Copy link
Contributor

nxsaken commented Sep 10, 2024

The clippy lint expectation is in the wrong place

@mversic
Copy link
Contributor

mversic commented Sep 10, 2024

The clippy lint expectation is in the wrong place

what's the right place? I tried different places

@nxsaken
Copy link
Contributor

nxsaken commented Sep 10, 2024

These work, better use the most specific place:

#[expect(unreachable_patterns)]
const fn on_fn() {
    let x = 5;
    match x {
        _y => (),
        5 => (),
    }
}

const fn in_fn() {
    let x = 5;

    #[expect(unreachable_patterns)]
    match x {
        _y => (),
        5 => (), // the unreachable arm fulfills the expectation
    }

    match x {
        _y => (),
        #[expect(unreachable_patterns)]
        5 => (),
    }
}

@mversic
Copy link
Contributor

mversic commented Sep 10, 2024

These work, better use the most specific place:

#[expect(unreachable_patterns)]
const fn on_fn() {
    let x = 5;
    match x {
        _y => (),
        5 => (),
    }
}

const fn in_fn() {
    let x = 5;

    #[expect(unreachable_patterns)]
    match x {
        _y => (),
        5 => (), // the unreachable arm fulfills the expectation
    }

    match x {
        _y => (),
        #[expect(unreachable_patterns)]
        5 => (),
    }
}

sure, but in this case it lint complains on the enum definition, not where it's used

mversic
mversic previously approved these changes Sep 10, 2024
@mversic mversic merged commit a6044a9 into hyperledger:main Sep 10, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bump Rust version
4 participants