Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(permissions): define default permission set #5075

Merged
merged 1 commit into from
Sep 27, 2024
Merged

refactor(permissions): define default permission set #5075

merged 1 commit into from
Sep 27, 2024

Conversation

mversic
Copy link
Contributor

@mversic mversic commented Sep 13, 2024 •
edited
Loading

Context

  • added CanManagePeers, CanRegisterDomain and CanManageRoles permissions
  • unified CanSetKeyValueXXX + CanRemoveKeyValueXXX = CanModifyXXXMetadata
  • unified CanMintAsset + CanBurnAsset + CanTransferAsset = CanModifyAsset
  • changed FindPermissions so it returns only inherent permissions, not from roles
  • fixed validation of grant/revoke for roles

closes #4206

Solution

  • Describe the approach taken to achieve the objective / resolve the issue.

Review notes (optional)

  • For complex PRs, try to provide some information on how to approach the review more effectively.
  • For example, is there a natural order in which the affected files should be reviewed?

Checklist

  • I've read CONTRIBUTING.md.
  • (optional) I've written unit tests for the code changes.
  • All review comments have been resolved.
  • All CI checks pass.

@mversic mversic force-pushed the default_permission_set branch 3 times, most recently from 8bc8495 to 208c2f0 Compare September 13, 2024 08:42
@github-actions github-actions bot added the api-changes Changes in the API for client libraries label Sep 13, 2024
nxsaken
nxsaken previously approved these changes Sep 13, 2024
View reviewed changes
@github-actions github-actions bot added the config-changes Changes in configuration and start up of the Iroha label Sep 13, 2024
@github-actions GitHub Actions
Copy link

@BAStos525

@mversic mversic force-pushed the default_permission_set branch 7 times, most recently from 906bb5b to 502a580 Compare September 15, 2024 05:43
@mversic mversic changed the title chore(permissions): define default permission set refactor(permissions): define default permission set Sep 15, 2024
@mversic mversic force-pushed the default_permission_set branch 2 times, most recently from d88ccc4 to cd94357 Compare September 15, 2024 06:07
@mversic mversic force-pushed the default_permission_set branch 4 times, most recently from 817ec0c to 45edafa Compare September 16, 2024 04:58
@mversic mversic assigned nxsaken and unassigned nxsaken and 0x009922 Sep 16, 2024
nxsaken
nxsaken previously approved these changes Sep 18, 2024
View reviewed changes
@Erigara Erigara self-assigned this Sep 19, 2024
Erigara
Erigara reviewed Sep 19, 2024
View reviewed changes
crates/iroha/tests/integration/asset.rs Outdated Show resolved Hide resolved
crates/iroha_executor/src/permission.rs Outdated Show resolved Hide resolved
@mversic mversic force-pushed the default_permission_set branch 5 times, most recently from 7efbc8c to b9445e8 Compare September 25, 2024 13:43
@mversic mversic force-pushed the default_permission_set branch 3 times, most recently from c08f7a2 to 1649d89 Compare September 26, 2024 04:55
0x009922
0x009922 approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@0x009922 0x009922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, but I lack the feeling of how much it is/was ergonomic for end users.

And, I guess a proper name for this PR would be "re-define and simplify default permission set", because it was already defined.

@mversic mversic mentioned this pull request Sep 27, 2024
Open
@mversic mversic merged commit 002803f into hyperledger:main Sep 27, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nxsaken nxsaken nxsaken approved these changes

@Erigara Erigara Erigara approved these changes

@0x009922 0x009922 0x009922 approved these changes

@s8sato s8sato Awaiting requested review from s8sato s8sato is a code owner

@SamHSmith SamHSmith Awaiting requested review from SamHSmith SamHSmith is a code owner

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@DCNick3 DCNick3 Awaiting requested review from DCNick3 DCNick3 is a code owner

@dima74 dima74 Awaiting requested review from dima74 dima74 is a code owner

Assignees

@nxsaken nxsaken

@Erigara Erigara

@mversic mversic

Labels
api-changes Changes in the API for client libraries config-changes Changes in configuration and start up of the Iroha
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define a set of default permission tokens
5 participants
@mversic @DCNick3 @nxsaken @Erigara @0x009922