Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HSM kms implementation #2105

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add HSM kms implementation #2105

wants to merge 2 commits into from
+107 −0

Conversation

gtebrean
Copy link
Contributor

@gtebrean gtebrean commented Oct 1, 2024

What does this PR do?

required

Where should the reviewer start?

required

Why is it needed?

required

Checklist

  • I've read the contribution guidelines.
  • I've added tests (if applicable).
  • I've added a changelog entry if necessary.

@gtebrean
add kms implementation
a60b61c 
Signed-off-by: gtebrean <[email protected]>
NickSneo
NickSneo reviewed Oct 2, 2024
View reviewed changes
Copy link
Contributor

@NickSneo NickSneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add some test cases?

@gtebrean
update changelog
cca45d1 
Signed-off-by: gtebrean <[email protected]>
@gtebrean
Copy link
Contributor Author

gtebrean commented Oct 2, 2024

Do we need to add some test cases?

can't be executed as a tes because will need to provide an AWS env with the KMS in order to can execute it, I tested it locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickSneo NickSneo NickSneo left review comments

@conor10 conor10 Awaiting requested review from conor10 conor10 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gtebrean @NickSneo