Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SingleUseSandbox #125

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

ludfjig
Copy link
Contributor

@ludfjig ludfjig commented Dec 26, 2024

Removes the singleusesandbox, as it serves no purpose. This is a first step towards refactoring the evolve, transition-func, etc., abstractions

@ludfjig ludfjig enabled auto-merge (squash) January 4, 2025 11:29
@simongdavies
Copy link
Contributor

We should consider renaming MultiUseSandbox after this, although I guess that will be a breaking change (I know this one is but AFAIK no one is using SingleUseSandbox)

Signed-off-by: Ludvig Liljenberg <[email protected]>
Copy link
Contributor

@danbugs danbugs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If you haven't already, might be worth searching for all text references of SingleUseSandbox to make sure we are not missing any mentions in documentation and so on.

@ludfjig ludfjig merged commit fd338e7 into hyperlight-dev:main Jan 22, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants