Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix typo #43

Merged
merged 4 commits into from
Nov 9, 2024
Merged

docs: fix typo #43

merged 4 commits into from
Nov 9, 2024

Conversation

samrose
Copy link
Contributor

@samrose samrose commented Nov 8, 2024

No description provided.

@jprendes
Copy link
Contributor

jprendes commented Nov 8, 2024

Hi! Thanks again for the contribution!
Would you mind following the instructions here to get the DCO step passing?

@samrose
Copy link
Contributor Author

samrose commented Nov 8, 2024

@jprendes there you go LOL

@jprendes jprendes added the area/documentation Improvements or additions to documentation label Nov 8, 2024
@jprendes jprendes enabled auto-merge (squash) November 8, 2024 11:49
@jprendes jprendes disabled auto-merge November 8, 2024 11:50
@jprendes
Copy link
Contributor

jprendes commented Nov 8, 2024

Sorry, would you mind also signing your commit?
https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

@samrose
Copy link
Contributor Author

samrose commented Nov 8, 2024

@jprendes there you go! ^^

devigned
devigned approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@devigned devigned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thank you.

@jprendes jprendes closed this Nov 8, 2024
@jprendes jprendes reopened this Nov 8, 2024
@jprendes jprendes merged commit 5de971c into hyperlight-dev:main Nov 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devigned devigned devigned approved these changes

@jprendes jprendes jprendes approved these changes

@dblnz dblnz dblnz approved these changes

Assignees
No one assigned
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samrose @jprendes @devigned @dblnz