refactor: corrected signature verification function name of BbsBlsSig…

…nature2020
hypersign-protocol · Sep 25, 2023 · 5c8f53b · 5c8f53b
1 parent e7f86b5
commit 5c8f53b
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/cmd/hid-noded/cmd/debug_extensions.go b/cmd/hid-noded/cmd/debug_extensions.go
@@ -343,7 +343,7 @@ func signSchemaDocCmd() *cobra.Command {
 					return err
 				}
 			case types.BbsBlsSignature2020:
-				signature, err = hidnodecli.GetBBSSignature(argPrivateKey, schemaDocBytes)
+				signature, err = hidnodecli.GetBbsBlsSignature2020(argPrivateKey, schemaDocBytes)
 				if err != nil {
 					return err
 				}
@@ -353,7 +353,7 @@ func signSchemaDocCmd() *cobra.Command {
 					return err
 				}
 			default:
-				panic("recieved unsupported signing-algo. Supported algorithms are: ['ed25519', 'secp256k1', 'recover-eth', 'bbs', 'bjj']")
+				panic("recieved unsupported signing-algo. Supported algorithms are: [Ed25519Signature2020, EcdsaSecp256k1Signature2019, EcdsaSecp256k1RecoverySignature2020, BbsBlsSignature2020, 'bjj']")
 			}
 
 			_, err = fmt.Fprintln(cmd.OutOrStdout(), signature)
@@ -405,7 +405,7 @@ func signCredStatusDocCmd() *cobra.Command {
 					return err
 				}
 			case types.BbsBlsSignature2020:
-				signature, err = hidnodecli.GetBBSSignature(argPrivateKey, credStatusDocBytes)
+				signature, err = hidnodecli.GetBbsBlsSignature2020(argPrivateKey, credStatusDocBytes)
 				if err != nil {
 					return err
 				}
@@ -415,7 +415,7 @@ func signCredStatusDocCmd() *cobra.Command {
 					return err
 				}
 			default:
-				panic("recieved unsupported signing-algo. Supported algorithms are: ['ed25519', 'secp256k1', 'recover-eth', 'bbs', 'bjj']")
+				panic("recieved unsupported signing-algo. Supported algorithms are: [Ed25519Signature2020, EcdsaSecp256k1Signature2019, EcdsaSecp256k1RecoverySignature2020, BbsBlsSignature2020, 'bjj']")
 			}
 
 			_, err = fmt.Fprintln(cmd.OutOrStdout(), signature)

diff --git a/x/ssi/client/cli/tx_utils.go b/x/ssi/client/cli/tx_utils.go
@@ -53,8 +53,8 @@ func extractDIDSigningElements(cmdArgs []string) ([]DIDSigningElements, error) {
 	return didSigningElementsList, nil
 }
 
-// GetBBSSignature signs a message and returns a BBS signature
-func GetBBSSignature(privateKey string, message []byte) (string, error) {
+// GetBbsBlsSignature2020 signs a message and returns a BBS signature
+func GetBbsBlsSignature2020(privateKey string, message []byte) (string, error) {
 	privKeyBytes, err := base64.StdEncoding.DecodeString(privateKey)
 	if err != nil {
 		panic(err)
@@ -200,7 +200,7 @@ func getSignatures(cmd *cobra.Command, didDoc *types.Did, cmdArgs []string) ([]*
 				return nil, err
 			}
 
-			signInfoList[i].Signature, err = GetBBSSignature(didSigningElementsList[i].SignKey, didDocBytes)
+			signInfoList[i].Signature, err = GetBbsBlsSignature2020(didSigningElementsList[i].SignKey, didDocBytes)
 			if err != nil {
 				return nil, err
 			}

diff --git a/x/ssi/verification/crypto.go b/x/ssi/verification/crypto.go
@@ -67,7 +67,7 @@ func verify(extendedVm *types.ExtendedVerificationMethod, ssiMsg types.SsiMsg) e
 	case types.X25519KeyAgreementKeyEIP5630:
 		return verifyX25519KeyAgreementKeyEIP5630Key(extendedVm)
 	case types.Bls12381G2Key2020:
-		return verifyBls12381G2Key2020Key(extendedVm, docBytes)
+		return verifyBbsBlsSignature2020(extendedVm, docBytes)
 	case types.BabyJubJubVerificationKey2023:
 		return verifyBabyJubJubVerificationKey2023Key(extendedVm, docBytes)
 	default:
@@ -121,8 +121,8 @@ func verifyBabyJubJubVerificationKey2023Key(extendedVm *types.ExtendedVerificati
 	return nil
 }
 
-// verifyBls12381G2Key2020Key verifies the verification key for verification method type Bls12381G2Key2020
-func verifyBls12381G2Key2020Key(extendedVm *types.ExtendedVerificationMethod, documentBytes []byte) error {
+// verifyBbsBlsSignature2020 verifies the verification key for verification method type BbsBlsSignature2020
+func verifyBbsBlsSignature2020(extendedVm *types.ExtendedVerificationMethod, documentBytes []byte) error {
 	bbsObj := bbs.New()
 
 	// Unlike in tranditional cryptographic algorithms where a message is signed as-is, the message in BBS+ Signature