-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Incur fixed cost for each x/ssi
message
#365
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v0.1.8-rc.2: Release
added v0.1.8 upgrade handler
v0.1.9: Release
arnabghose997
changed the title
Added
feat: Incur fixed cost for each SSI message
Aug 12, 2023
x/identityfee
module to make SSI transaction incur fixed cost
arnabghose997
changed the title
feat: Incur fixed cost for each SSI message
feat: Incur fixed cost for each Aug 12, 2023
x/ssi
message
Vishwas1
approved these changes
Nov 8, 2023
…ture2023 signed document
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to make
x/ssi
message incur fixed fees. Fees for each message is distinct and parameterised underx/ssi
module. The rationale behind this has been described in HIP-9.Implementation
Rules
MsgCreateDID
), then it will incur the exact cost as the currentCreateDID
fee. This is irrespective of the size of the messageMsgCreateDID
costs4000uhid
andMsgCreateSchema
costs2000uhid
, the required fees would be6000uhid
7500uhid
, the user must provide7500uhid
as fee. Any value above or below7500uhid
is treated as invalid.Ante Handlers
The
x/ssi
ante handlersSSITxDecorator
,MempoolFeeDecorator
andDeductFeeDecorator
come together to perform the necessary verification to filter fixed-fee SSI messages and nominal non-SSI messages, and meter fixed charge for SSI messages. Order of calling ante handlers is crucial, and hence the position of these handlers should not be changed, unless a logic change is needed.Governance Proposal
Any change of fee parameters of SSI transactions can be done by submitting a
Param Change
Governance Proposal. This type of Governance Proposal requires a JSON file (if done through CLI), describing the new values for consensus parameter(s), to be provided. Following is the format for changing the fixed-fee value ofMsgCreateDID
to4578uhid
Querying current fixed fee
Querying the current fixed-fee for SSI transactions can be done through following methods: