fixed JSON-LD canonization; added client proto package to define governed constants for external clients
#376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce with EdDsaCryptoSuite2020 W3C specification; this includes canonizing the document using RDF dataset normalization and expecting publicKeyMutibase of verification method type Ed25519VerificationKey2020 to carry a 2-byte prefix as described in the said specification
…LD struct. This issue was solved by converting the jsonLd struct to an interface{} object and fed to the normalize function
- SSI proto package name has been renamed from hypersignprotocol.hidnode.ssi to hypersign.ssi.v1 - Client Spec has been reduced to an enum type. ADR036Signer address is infered from the blockchainAccountId - A common Proof message is introduced for DID, Credential Schema and Credential Status documents. It also replaces the existing Schema Proof, Credential Status Proof and DID SignInfo messages. Proof message is only stored on-chain for Credential Schema and Credential Status - Credential Status message has been revamped by eliminating statuses such as Live and Expired. Only Revocation and Suspension is tracked. Claim message has been discarded, making fields such as id, remarks part of the main Credential Status message. The attribute credentialHash has been renamed to merkleRootHash to indicate that the Hash represents the Merkle Root Hash of the VC - CreateDID RPC has been renamed to RegisterDID. Updates of any CredentialStatus document will done through a seperate RPC: UpdateCredentialStatus. Updates of any CredentialStatus document will done through a seperate RPC: UpdateCredentialSchema. - json_name proto tag has been added to context attribute of DidDocument to support @context field in generated TS client - protocgen-ts.sh script has been added to generate TS client files. This approach provides more flexibility in terms of generation options compared to using ignite CLI tool
…g proof object as well
… for external clients
…pdating credential status
…happens when incoming vc status document has changes
…outside of the package
…eplaced by setDidDocumentInStore since both methods had similar interaction with store, with the exception that in case of latter the did doc count was incremented by 1, which is seperated in a different method
… added context for X25519KeyAgreementKeyEIP5630 type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON-LD canonization fix
The initial assumption of JSON-LD canonization was to only canonize the document (without
proofattribute), hash the canonized string and sing it. However, the actual process involves canonizingproofattribute as well. The detailed flow can be referred hereclientproto package.Addresses: #375
The protocol supports selected Verification Method and Proof Types. In order to dictate these terms to external clients, such as SDK written is TS or any other language,
clientproto package was created to export enums for all the supported types. Refer the directoryproto/ssi/client/enums.proto