-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix getting version #187
Fix getting version #187
Conversation
- debian use `dist-packages` instead of `site-packages` - dev version, opt in to use setuptools_scm when possible, for example for non shallow checkout
73f4e5c
to
96b9fc9
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #187 +/- ##
==========================================
- Coverage 86.02% 86.01% -0.01%
==========================================
Files 81 81
Lines 10387 10390 +3
Branches 2253 2254 +1
==========================================
+ Hits 8935 8937 +2
Misses 931 931
- Partials 521 522 +1 ☔ View full report in Codecov by Sentry. |
@CSSFrancis, @magnunor, can you please have a look at this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like pretty sound logic to me. @magnunor If you want to test things to make sure that they work as intended for your case that would be good.
My suggestions are just some small documentation things to make it a bit clearer as to what is happening.
… update fallback version
96b9fc9
to
136a7dc
Compare
Thank you @CSSFrancis, this was poorly and I was a bit lazy to improve it! 😅 This should be better now! |
No problem :) I think I'm much worse at that than you are. This looks good to me |
Checking this now! |
That fixed the issue (#184)! |
Alternative to #185.
Progress of the PR
fallback_version
at build time to define version when necessary version control information are missing (git archive or shallow checkout). When making a new release, thefallback_version
will be updated automatically by theprepare_release.py
script,setuptools_scm
at runtime only when possible,upcoming_changes
folder (seeupcoming_changes/README.rst
),docs/readthedocs.org:rosettasciio
build of this PR (link in github checks)