-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rsciio.set_log_level
to set the logging level
#192
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #192 +/- ##
==========================================
- Coverage 86.17% 86.16% -0.02%
==========================================
Files 82 82
Lines 10475 10503 +28
Branches 2275 2276 +1
==========================================
+ Hits 9027 9050 +23
- Misses 931 936 +5
Partials 517 517 ☔ View full report in Codecov by Sentry. |
doc/api/index.rst
Outdated
@@ -69,4 +69,8 @@ for reading/writing of data files: | |||
* `Kikuchipy <https://kikuchipy.org>`_: Processing, simulating and analyzing | |||
electron backscatter diffraction (EBSD) patterns in Python | |||
* `PyXem <https://pyxem.readthedocs.io>`_: An open-source Python library for | |||
multi-dimensional diffraction microscopy. | |||
multi-dimensional diffraction microscopy. | |||
* `exSpy <https://hyperspy.org/exspy/>`_: Analysis of X-rays Energy Dispersive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* `exSpy <https://hyperspy.org/exspy/>`_: Analysis of X-rays Energy Dispersive | |
* `exSpy <https://hyperspy.org/exspy/>`_: Analysis of Energy Dispersive X-ray |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As both are used and valid, I simply removed the "s". I usually prefer the X-ray EDS because it is consistent with EELS and it is consistent with our use of EDS, as opposed to EDX.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I have seen either of the abbreviations EDS/EDX for "Energy Dispersive X-ray Spectroscopy" (11.5 M hits on google) and had not come across putting the "X-ray" first so far (125k hits on google) .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is used in the Williams & Carter book (but also in reference paper by Zaluzec or Watanabe), which I use most of the times as reference for this topic and I guess this is why I tend to use this wording.
Closes #69.
Progress of the PR
rsciio.set_log_level
,upcoming_changes
folder (seeupcoming_changes/README.rst
),docs/readthedocs.org:rosettasciio
build of this PR (link in github checks)Minimal example of the bug fix or the new feature