Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #300

Merged
merged 5 commits into from
Aug 6, 2024
Merged

Fix CI #300

merged 5 commits into from
Aug 6, 2024

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Aug 5, 2024

Progress of the PR

  • Pin towncrier to <24 until sphinxcontrib-towncrier supports towncrier >=24,
  • fix broken link,
  • make the oldest supported version are correctly installed,
  • bump dask mininum requirement to align with hyperspy - convenience to simplify CI
  • [n/a] update docstring (if appropriate),
  • [n/a] update user guide (if appropriate),
  • [n/a] add a changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • [n/a] Check formatting of the changelog entry (and eventual user guide changes) in the docs/readthedocs.org:rosettasciio build of this PR (link in github checks)
  • [n/a] add tests,
  • ready for review.

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.67%. Comparing base (e1fc1b0) to head (04e5aff).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #300   +/-   ##
=======================================
  Coverage   87.66%   87.67%           
=======================================
  Files          83       83           
  Lines       11149    11149           
  Branches     2414     2414           
=======================================
+ Hits         9774     9775    +1     
  Misses        860      860           
+ Partials      515      514    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlaehne jlaehne merged commit 8388ed6 into hyperspy:main Aug 6, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants