Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.7 #349

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Release 0.7 #349

merged 2 commits into from
Dec 20, 2024

Conversation

CSSFrancis
Copy link
Member

@CSSFrancis CSSFrancis commented Dec 16, 2024

Description of the change

A few sentences and/or a bulleted list to describe and motivate the change:

  • Prepare Release using python script
  • Add tag to test if package builds correctly
  • Push changes to pypi
  • Make sure conda-forge workflow passes.

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.84%. Comparing base (c7de7d0) to head (cd3ba78).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #349   +/-   ##
=======================================
  Coverage   87.84%   87.84%           
=======================================
  Files          85       85           
  Lines       11246    11246           
  Branches     2084     2084           
=======================================
  Hits         9879     9879           
  Misses        868      868           
  Partials      499      499           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CSSFrancis CSSFrancis requested a review from ericpre December 16, 2024 17:19
Copy link
Member

@ericpre ericpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at https://github.com/ericpre/rosettasciio/actions/runs/12359210409, the python 3.13 wheels are not built. It would be good to add these by updating accordingly (remove cp313*?):

# CPython 3.13 not supported yet because of pint
CIBW_SKIP: "{pp*,cp313*,*-musllinux*,*win32,*-manylinux_i686}"

Sorry this should have been done in #339!

Other than that, this looks good! 😃

@jlaehne
Copy link
Member

jlaehne commented Dec 16, 2024

Can we get the small bug-fix in #347 into this release?

@ericpre
Copy link
Member

ericpre commented Dec 19, 2024

Rebased to include #347 and added build of python 3.13 wheels.

@ericpre
Copy link
Member

ericpre commented Dec 19, 2024

The release workflow passes: https://github.com/ericpre/rosettasciio/actions/runs/12415083421

@ericpre ericpre changed the title Release: Make new release for rosettasciio. Release 0.7 Dec 20, 2024
@ericpre
Copy link
Member

ericpre commented Dec 20, 2024

@ericpre ericpre added this to the v0.7 milestone Dec 20, 2024
@ericpre ericpre merged commit f4933ca into hyperspy:main Dec 20, 2024
44 checks passed
@jlaehne
Copy link
Member

jlaehne commented Dec 22, 2024

On the conda feedstock the windows tests are not running through:
conda-forge/rosettasciio-feedstock#11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants