-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.7 #349
Release 0.7 #349
Conversation
9509239
to
d2a5d24
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #349 +/- ##
=======================================
Coverage 87.84% 87.84%
=======================================
Files 85 85
Lines 11246 11246
Branches 2084 2084
=======================================
Hits 9879 9879
Misses 868 868
Partials 499 499 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at https://github.com/ericpre/rosettasciio/actions/runs/12359210409, the python 3.13 wheels are not built. It would be good to add these by updating accordingly (remove cp313*
?):
rosettasciio/.github/workflows/release.yml
Lines 26 to 27 in 4e67875
# CPython 3.13 not supported yet because of pint | |
CIBW_SKIP: "{pp*,cp313*,*-musllinux*,*win32,*-manylinux_i686}" |
Sorry this should have been done in #339!
Other than that, this looks good! 😃
Can we get the small bug-fix in #347 into this release? |
d2a5d24
to
a1b0669
Compare
a1b0669
to
191c504
Compare
Rebased to include #347 and added build of python 3.13 wheels. |
The release workflow passes: https://github.com/ericpre/rosettasciio/actions/runs/12415083421 |
191c504
to
cd3ba78
Compare
On the conda feedstock the windows tests are not running through: |
Description of the change
A few sentences and/or a bulleted list to describe and motivate the change: