Skip to content

Commit

Permalink
addressed pr comment
Browse files Browse the repository at this point in the history
  • Loading branch information
RishabhB99 committed Jul 2, 2024
1 parent 46737e1 commit 948d214
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
import java.util.Objects;
import java.util.Optional;
import java.util.stream.Collectors;
import org.apache.commons.collections4.CollectionUtils;
import org.apache.commons.collections4.MapUtils;
Expand Down Expand Up @@ -151,10 +151,12 @@ public static boolean isFunctionExpressionSelectionWithGroupBy(
&& (Boolean) selectionSpec.getExpression().accept(FUNCTION_EXPRESSION_CHECKER);
}

@SuppressWarnings("unchecked")
public static List<String> getGroupByAliases(final List<GroupTypeExpression> expressions) {
return expressions.stream()
.map(expression -> (String) expression.accept(GROUP_BY_ALIAS_GETTER))
.filter(Objects::nonNull)
.map(expression -> (Optional<String>) expression.accept(GROUP_BY_ALIAS_GETTER))
.filter(Optional::isPresent)
.map(Optional::get)
.collect(Collectors.toUnmodifiableList());
}
}
Original file line number Diff line number Diff line change
@@ -1,18 +1,19 @@
package org.hypertrace.core.documentstore.parser;

import java.util.Optional;
import org.hypertrace.core.documentstore.expression.impl.FunctionExpression;
import org.hypertrace.core.documentstore.expression.impl.IdentifierExpression;

@SuppressWarnings("unchecked")
public class GroupByAliasGetter implements GroupTypeExpressionVisitor {

@Override
public String visit(FunctionExpression expression) {
return null;
public Optional<String> visit(FunctionExpression expression) {
return Optional.empty();

Check warning on line 12 in document-store/src/main/java/org/hypertrace/core/documentstore/parser/GroupByAliasGetter.java

View check run for this annotation

Codecov / codecov/patch

document-store/src/main/java/org/hypertrace/core/documentstore/parser/GroupByAliasGetter.java#L12

Added line #L12 was not covered by tests
}

@Override
public String visit(IdentifierExpression expression) {
return expression.getName();
public Optional<String> visit(IdentifierExpression expression) {
return Optional.of(expression.getName());
}
}

0 comments on commit 948d214

Please sign in to comment.