-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
46737e1
commit 948d214
Showing
2 changed files
with
10 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 5 additions & 4 deletions
9
...ment-store/src/main/java/org/hypertrace/core/documentstore/parser/GroupByAliasGetter.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,19 @@ | ||
package org.hypertrace.core.documentstore.parser; | ||
|
||
import java.util.Optional; | ||
import org.hypertrace.core.documentstore.expression.impl.FunctionExpression; | ||
import org.hypertrace.core.documentstore.expression.impl.IdentifierExpression; | ||
|
||
@SuppressWarnings("unchecked") | ||
public class GroupByAliasGetter implements GroupTypeExpressionVisitor { | ||
|
||
@Override | ||
public String visit(FunctionExpression expression) { | ||
return null; | ||
public Optional<String> visit(FunctionExpression expression) { | ||
return Optional.empty(); | ||
Check warning on line 12 in document-store/src/main/java/org/hypertrace/core/documentstore/parser/GroupByAliasGetter.java Codecov / codecov/patchdocument-store/src/main/java/org/hypertrace/core/documentstore/parser/GroupByAliasGetter.java#L12
|
||
} | ||
|
||
@Override | ||
public String visit(IdentifierExpression expression) { | ||
return expression.getName(); | ||
public Optional<String> visit(IdentifierExpression expression) { | ||
return Optional.of(expression.getName()); | ||
} | ||
} |