make inclause behaviour consistent between mongo and postgres #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #186 +/- ##
============================================
+ Coverage 80.60% 80.63% +0.03%
- Complexity 932 933 +1
============================================
Files 149 149
Lines 4275 4292 +17
Branches 356 356
============================================
+ Hits 3446 3461 +15
- Misses 590 591 +1
- Partials 239 240 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
...ment-store/src/main/java/org/hypertrace/core/documentstore/postgres/utils/PostgresUtils.java
Outdated
Show resolved
Hide resolved
...ment-store/src/main/java/org/hypertrace/core/documentstore/postgres/utils/PostgresUtils.java
Outdated
Show resolved
Hide resolved
...ment-store/src/main/java/org/hypertrace/core/documentstore/postgres/utils/PostgresUtils.java
Outdated
Show resolved
Hide resolved
...-store/src/test/java/org/hypertrace/core/documentstore/postgres/PostgresQueryParserTest.java
Outdated
Show resolved
Hide resolved
...ment-store/src/main/java/org/hypertrace/core/documentstore/postgres/utils/PostgresUtils.java
Outdated
Show resolved
Hide resolved
SrikarMannepalli
requested review from
avinashkolluru,
kotharironak and
skjindal93
as code owners
...ment-store/src/main/java/org/hypertrace/core/documentstore/postgres/utils/PostgresUtils.java
Outdated
Show resolved
Hide resolved
...ment-store/src/main/java/org/hypertrace/core/documentstore/postgres/utils/PostgresUtils.java
Show resolved
Hide resolved
...ment-store/src/main/java/org/hypertrace/core/documentstore/postgres/utils/PostgresUtils.java
Outdated
Show resolved
Hide resolved
...ment-store/src/main/java/org/hypertrace/core/documentstore/postgres/utils/PostgresUtils.java
Outdated
Show resolved
Hide resolved
...ment-store/src/main/java/org/hypertrace/core/documentstore/postgres/utils/PostgresUtils.java
Outdated
Show resolved
Hide resolved
...ment-store/src/main/java/org/hypertrace/core/documentstore/postgres/utils/PostgresUtils.java
Outdated
Show resolved
Hide resolved
...ment-store/src/main/java/org/hypertrace/core/documentstore/postgres/utils/PostgresUtils.java
Outdated
Show resolved
Hide resolved
...nt-store/src/integrationTest/resources/query/test_primitive_lhs_in_filter_aggr_response.json
Outdated
Show resolved
Hide resolved
...ment-store/src/main/java/org/hypertrace/core/documentstore/postgres/utils/PostgresUtils.java
Outdated
Show resolved
Hide resolved
...ment-store/src/main/java/org/hypertrace/core/documentstore/postgres/utils/PostgresUtils.java
Outdated
Show resolved
Hide resolved
...ment-store/src/main/java/org/hypertrace/core/documentstore/postgres/utils/PostgresUtils.java
Outdated
Show resolved
Hide resolved
|
Only nits. Overall, looks good. |
suresh-prakash
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.