Handle the zero limit case explicitly for MongoDB aggregation #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suresh-prakash
requested review from
avinashkolluru,
kotharironak and
skjindal93
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #187 +/- ##
============================================
- Coverage 80.71% 80.60% -0.12%
- Complexity 931 932 +1
============================================
Files 149 149
Lines 4258 4275 +17
Branches 354 356 +2
============================================
+ Hits 3437 3446 +9
- Misses 585 590 +5
- Partials 236 239 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kotharironak
approved these changes
Dec 12, 2023
suresh-prakash
deleted the
handle_zero_limit_case_for_mongo_aggregation
branch
Does it return no documents or all 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MongoDB
find()implementation handles the 0-limit case and returns no documents.Whereas the deprecation alternative method
aggregate()implementation throws an exception on a 0-limit for MongoDB, while it works as expected for Postgres.This PR aims at fixing that bug by manually handling the 0-limit case (as there is no way to handle this in MongoDB aggregation pipeline) and adds an integration test to cover that scenario.