Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce configurability of the new parameters #212

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

suresh-prakash
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.81%. Comparing base (0dc1bec) to head (5911a19).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...config/TypesafeConfigDatastoreConfigExtractor.java 91.30% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #212      +/-   ##
============================================
- Coverage     79.81%   79.81%   -0.01%     
- Complexity     1040     1044       +4     
============================================
  Files           199      199              
  Lines          4945     4953       +8     
  Branches        412      414       +2     
============================================
+ Hits           3947     3953       +6     
  Misses          710      710              
- Partials        288      290       +2     
Flag Coverage Δ
integration 79.81% <91.66%> (-0.01%) ⬇️
unit 57.62% <91.66%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Test Results

 40 files  ±0   40 suites  ±0   34s ⏱️ +2s
247 tests ±0  247 ✅ ±0  0 💤 ±0  0 ❌ ±0 
500 runs  ±0  500 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 5911a19. ± Comparison against base commit 0dc1bec.

@suresh-prakash suresh-prakash merged commit 9b4eb6e into main Sep 26, 2024
6 of 7 checks passed
@suresh-prakash suresh-prakash deleted the introduce_new_properties_in_the_converter branch September 26, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants