EN-51893 | CHORE : Adding Last aggregation operator #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singh-viikram
requested review from
avinashkolluru,
kotharironak,
skjindal93 and
suresh-prakash
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #215 +/- ##
=========================================
Coverage 79.71% 79.72%
Complexity 1043 1043
=========================================
Files 199 199
Lines 4939 4941 +2
Branches 410 410
=========================================
+ Hits 3937 3939 +2
Misses 711 711
Partials 291 291
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
document-store/src/integrationTest/resources/query/test_last_aggregation_operator.json
Show resolved
Hide resolved
| @@ -0,0 +1,18 @@ | |||
| [ | |||
| { | |||
| "item":"Shampoo", | |||
There was a problem hiding this comment.
Nit: Could you please prettify the JSON (specifically spaces before the values)?
Suggested change
| "item":"Shampoo", | |
| "item": "Shampoo", |
...nt-store/src/integrationTest/java/org/hypertrace/core/documentstore/DocStoreQueryV1Test.java
Outdated
Show resolved
Hide resolved
suresh-prakash
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change, motivation and context.
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.