Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added hiphen in subdocpath #216

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

shubham-gupta23
Copy link
Contributor

@shubham-gupta23 shubham-gupta23 commented Nov 14, 2024

Description

This will allow subdocpath to have "-" in it. It will be used in cases where we want to add negative values to a map to list.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.72%. Comparing base (0723c9d) to head (0b52369).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #216   +/-   ##
=========================================
  Coverage     79.72%   79.72%           
  Complexity     1043     1043           
=========================================
  Files           199      199           
  Lines          4941     4941           
  Branches        410      410           
=========================================
  Hits           3939     3939           
  Misses          711      711           
  Partials        291      291           
Flag Coverage Δ
integration 79.72% <100.00%> (ø)
unit 57.68% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 14, 2024

Test Results

 40 files  ±0   40 suites  ±0   31s ⏱️ -1s
246 tests ±0  246 ✅ ±0  0 💤 ±0  0 ❌ ±0 
500 runs  ±0  500 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0b52369. ± Comparison against base commit 0723c9d.

♻️ This comment has been updated with latest results.

@shubham-gupta23 shubham-gupta23 changed the title ENG-0000 added hiphen in subdocpath added hiphen in subdocpath Nov 15, 2024
@shubham-gupta23 shubham-gupta23 merged commit 23a9656 into main Nov 15, 2024
7 checks passed
@shubham-gupta23 shubham-gupta23 deleted the document_store_allowed_subdocpath_update branch November 15, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants