Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

chore: add filter on lastUpdatedTime for entities query #182

Closed
wants to merge 1 commit into from

Conversation

saxenakshitiz
Copy link
Contributor

No description provided.

@saxenakshitiz saxenakshitiz requested a review from a team as a code owner November 2, 2023 10:16
Copy link

github-actions bot commented Nov 2, 2023

Test Results

361 tests  ±0   361 ✔️ ±0   12s ⏱️ +2s
  66 suites ±0       0 💤 ±0 
  66 files   ±0       0 ±0 

Results for commit a49e8aa. ± Comparison against base commit 1997536.

This pull request removes 29 and adds 14 tests. Note that renamed tests count towards both.

      long: 60
      string: "PT1M"
      valueType: LONG
      valueType: STRING
    alias: "numCalls"
    columnName: "SERVICE.numCalls"
    value {
    }
  columnIdentifier {
…
org.hypertrace.gateway.service.baseline.BaselineServiceImplTest ‑ [1] function: AVGRATE
arguments {
  columnIdentifier {
    columnName: "SERVICE.numCalls"
    alias: "numCalls"
  }
}
arguments {
  literal {
    value {
      valueType: STRING
      string: "PT1M"
    }
  }
}
alias: "numCalls"

org.hypertrace.gateway.service.baseline.BaselineServiceImplTest ‑ [2] function: AVGRATE
arguments {
  columnIdentifier {
    columnName: "SERVICE.numCalls"
    alias: "numCalls"
  }
}
arguments {
  literal {
    value {
      valueType: LONG
      long: 60
    }
  }
}
alias: "numCalls"

org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [10] aggregations-with-groupby-and-the-rest-deprecated
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [11] simple-selection
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [12] time-aggregations-space-filtered
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [1] group-by-with-offset
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [2] grouped-time-aggregation-with-group-limit
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [3] group-by-with-group-limit-and-rest
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [4] aggregations-with-multiple-groupbys-and-the-rest-deprecated
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [5] group-by-with-group-limit
…

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #182 (a49e8aa) into main (1997536) will increase coverage by 0.04%.
The diff coverage is 95.00%.

@@             Coverage Diff              @@
##               main     #182      +/-   ##
============================================
+ Coverage     81.40%   81.45%   +0.04%     
- Complexity     1327     1329       +2     
============================================
  Files           125      125              
  Lines          5964     5984      +20     
  Branches        490      491       +1     
============================================
+ Hits           4855     4874      +19     
  Misses          865      865              
- Partials        244      245       +1     
Flag Coverage Δ
unit 81.45% <95.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rters/EntityServiceAndGatewayServiceConverter.java 42.41% <95.00%> (+3.89%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@saxenakshitiz saxenakshitiz deleted the add_filter_on_lastUpdatedTime branch November 3, 2023 08:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant